Support adding comments via the UI about git-appraise-web HOT 2 OPEN

@ojarjur, thanks for the outline.

I'd argue that commenting on a LoC or comment hash (via cli) is the most cumbersome part compared to pushing/pulling. So, IMO, implementing the former in the UI first would be more beneficial to the overall usability, unless I'm missing something in this equation.

So, agreeing that the easiest way to go forward is to implement it only for "local mode", I think the flow would be something like:

1. pull updates via CLI
2. launch git-appraise-web UI
3. add comments via the UI
4. close the UI or leave it running
5. push updates via CLI

All that is not to say that push/pull button wouldn't be a great thing to have. Thoughts?

from git-appraise-web.

@romansergey Thanks for the feedback! I've added my thoughts inline:

I'd argue that commenting on a LoC or comment hash (via cli) is the most cumbersome part compared to pushing/pulling.

I agree with that.

So, IMO, implementing the former in the UI first would be more beneficial to the overall usability, unless I'm missing something in this equation.

I can see that argument. However, we could also improve the CLI experience for that flow.

Specifically, we could have an "interactive" mode for commenting which presents the entire review quoted in a file (in a format like what you would expect for review-by-mailing-list solutions). The user could then edit that file, and the CLI could extract all of the comments from them and add them all at once.

Most of the logic for doing that will be required for email support anyway, so I do hope to get to that eventually.

So, agreeing that the easiest way to go forward is to implement it only for "local mode", I think the flow would be something like:

1. pull updates via CLI
2. launch git-appraise-web UI
3. add comments via the UI
4. close the UI or leave it running
5. push updates via CLI

All that is not to say that push/pull button wouldn't be a great thing to have. Thoughts?

This would be good, but there is one risk that I would be worried about; a user adding their comments locally, forgetting to push them, and then wondering why no one ever responds to them.

Granted, this is a risk with the CLI too, but as we try to make the whole flow more user friendly, the importance of addressing this becomes greater.

I suspect that we want to at least have some sort of visual indicator to the user that some comments have not yet been pushed to the remote. Now that I think about it, we should probably have that for the CLI too.

from git-appraise-web.