Comments (4)
Thanks for the further clarifications; I think I understand the issue now.
To fix this, I think we need to extend the plugin to support arbitrary target refs and not just 'refs/heads/master'.
The command line tool (git-appraise) does support arbitrary target refs, but we didn't include that level of flexibility in the eclipse plugin. There's nothing intrinsically hard about that... it just got overlooked.
So, what you will want (once we add the necessary support for specifying the target ref) is to:
- Checkout your feature branch (e.g. "feature/my-new-feature").
- Make your changes there and commit.
- Create a new review task specifying the "develop" branch as the target.
Until we have that, there are a couple of workarounds you could try:
- Use the 'git-appraise' command line tool to actually create the review.
- Create a local 'master' branch that is set up to track the remote 'develop' branch.
from git-appraise-eclipse.
Thanks for reaching out. I have a couple of follow up questions:
- To clarify, the two steps you listed for creating the review query completed without reporting any errors, right? (i.e. the error was in creating the new task, not in creating the query).
- What's the starting state of your repository?
If the git repository is completely empty (i.e. you just ran git init
and haven't committed anything yet) or the master
branch is missing (i.e. you ran git init
immediately followed by something like git checkout -b my-feature-branch
), then you would see this message.
The issue in those cases is that it wants to create a new review comparing the current branch to the master branch, but the master branch doesn't exist, so it reports that using a rather opaque message.
We could support that use case (reviewing the first commit in a repository) with some code changes, but it hasn't been a high priority yet since there is a simple work-around (first commit a README file, then checkout your feature branch and commit the first code changes).
from git-appraise-eclipse.
Hi @ojarjur, sorry ... my initial description was wrong :(
The error happens if I try to create a new review task ...
I select the appraise repo and click "finish" then this error pops up. I'm using the jgitflow process for the repo ... and yes there is no master branch. So I'm at the "development" branch.
Here is my project git layout ...
What happens if the master branch is write protected?
from git-appraise-eclipse.
Currently we switched to "crucible" ... so I have not the time to try that :(
from git-appraise-eclipse.
Related Issues (4)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from git-appraise-eclipse.