Git Product home page Git Product logo

Comments (3)

poletti-marco avatar poletti-marco commented on May 1, 2024

by default it would be a static one.

I think that this is a significant behavior change that would happen with this proposed change.
Of course I can easily modify the setting used for CI, that's not a problem; however, I want to make shared libraries the default for Fruit users, while still giving the option to build Fruit as a static library if desired.

One possible way around this could be to rename the CMake option to e.g. FRUIT_AS_STATIC_LIB or something like that. However this change might break some users that are currently passing -DBUILD_SHARED_LIBS, and it might do so silently (Fruit will still build; if their project's build doesn't break they would end up silently switching to using a shared library).
Do you see any alternative fix that would not cause this?

I'm adding fruit project as a subdirectory in my project

Maybe I should have asked earlier, but could you please explain better your use case? Why do you do that instead of downloading the latest Fruit version and compiling that once (as a static or shared library, and with any other flags you might want) and then linking against it from your project?
This way to build Fruit is not officially supported (still, I'm still happy to discuss and merge any change that makes your life easier in this use case without negatively impacting other Fruit users).

from fruit.

poletti-marco avatar poletti-marco commented on May 1, 2024

Note: I'm still interested in understanding and addressing your use case, but without more information it's hard for me to suggest alternative solutions to your problem, or to be convinced that we should do the change you propose.
Please provide additional information on your use case.

from fruit.

poletti-marco avatar poletti-marco commented on May 1, 2024

Without additional information, I'm afraid there is little I can do here.
Feel free to re-open if you're still interested in this; in that case please provide the information above.

from fruit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.