Comments (11)
Agreed, sounds like a good feature.
from flatbuffers.
Good, especially if this library is described as "Memory Efficient Serialization Library" so adding this feature should be a core feature, I also plan to use it with Netty which use pooling also.
It could be something like this:
public FlatBufferBuilder(ByteBuffer bb)
{
this.bb = bb;
this.bb.order(ByteOrder.LITTLE_ENDIAN);
space=this.bb.position();
}
from flatbuffers.
why space=this.bb.position()
? FlatBuffers writes to ByteBuffers in an absolute way, and does not rely on position() being anywhere in particular. space
represents the amount of space left over at the beginning of the buffer, so should be set to the size of the backing array at the start.
from flatbuffers.
Just added such a constructor as part of the last commit.
from flatbuffers.
That is good, thank you,
from flatbuffers.
I see that you clear the Buffer before using it, what if the buffer contains other data? But i don't know if this is a possible scenario!
from flatbuffers.
the clear() call only resets the writable area, it doesn't actually clear
the bytes. But yes, to create a FlatBuffer, you want to be using the entire
ByteBuffer, concatenating isn't supported.
from flatbuffers.
I think there is another problem with direct buffers, they don't have array(), and the FlatBufferBuilder uses it a lot so it will cause a problem.
I think you should throw UnsuportedOperationException if the the provided buffer has no array (make a call to hasArray() to know that)
from flatbuffers.
ok, will add that.
from flatbuffers.
- It could be a better solution to use bb.capacity() instead of dd.array().length; I did a Replace All in my code editor and test it and it did work, you can do more testing.
- You should also avoid the use of bb.array() and System.arrayCopy like in fbb.growByteBuffer() and fbb.createString. You should use bb.put(byte[]) and bb.get(byte[]) instead.
- i think growByteBuffer() and newByteBuffer() should be static functions.
from flatbuffers.
- I already did that.
- The reason I didn't use put and get is that there are no absolute versions of those calls available, meaning you need to explicitly set the position.. though I suppose that is no big deal.
- Agreed.
from flatbuffers.
Related Issues (20)
- rust-flatbuffers: Upgrading from flat 1.12 to 25.x
- rust-flatbuffers: Alignment issue
- --force-empty only support cpp ?
- Conflicts with Rust `core` module in code generated by flatc 23.5.26. HOT 1
- ReleaseRaw cannot be used with custom allocators [C++]
- [kotlin-kmp] Enums only files skipped when multiple schemas are used as input HOT 1
- Assertion `!nested' failed.
- [Python] No functional API to create a flatbuffer
- Question on using Flatbuffers for high performance research application
- Rust: FlatBuffers are impossible to return from functions
- Is it binary-compatible to delete (required) attribute?
- [Python] Use 'T' suffix object for serialization
- [swift] distinguish unknown from absent enum value for scheme evolution HOT 5
- undocumented breaking change GenerateText->GenText
- [Java, FlatBuffers 23.5.26, Mac OS 14.3] getByKey returns null while accessing using vector index works
- `get_root_as_*` functions not generated [Rust, 23.5.26, Linux] HOT 1
- Generating schemas with language adapters (as optional add-ons)?
- Streaming flatbuffers in java HOT 1
- [TS] optional escalar not set in the binary when it holds value 0 HOT 13
- Release a new version, please HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from flatbuffers.