Using a recent dev version of Dart, like 2.0.0-dev.55.0 or so: <div class="highlig

Partially blocked by <a class="issue-link js-issue-link" data-error-text="Failed to lo

CC <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="

Specifically this failure: <div class="snippet-clipboard-content notranslate posit

Is anyone looking at this? cc <a class="user-mention notranslate" data-hovercard-type=

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

I think it was only partially blocked by <a class="issue-link js-issue-link" data-erro

Some more context carried over from <a class="issue-link js-issue-link" data-error-tex

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

Dart 2 runtime cast failures about file.dart HOT 11 CLOSED

google commented on April 28, 2024

Dart 2 runtime cast failures

from file.dart.

Comments (11)

srawlins commented on April 28, 2024

Partially blocked by dart-lang/sdk#33459.

from file.dart.

srawlins commented on April 28, 2024

CC @tvolkert

from file.dart.

srawlins commented on April 28, 2024

Specifically this failure:

NoSuchMethodError: The method 'encode' was called on null....
NoSuchMethodError: The method 'encode' was called on null.
Receiver: null
Tried calling: encode("foo")
dart:core                                                 Object.noSuchMethod
package:file/src/backends/memory/memory_file.dart 273:33  MemoryFile.writeAsStringSync
package:file/src/backends/memory/memory_file.dart 262:5   MemoryFile.writeAsString
===== asynchronous gap ===========================
dart:async                                                _AsyncAwaitCompleter.completeError
package:file/src/backends/memory/memory_file.dart         MemoryFile.writeAsString

is caused by dart-lang/sdk#33459

from file.dart.

mit-mit commented on April 28, 2024

Is anyone looking at this? cc @tvolkert

from file.dart.

tvolkert commented on April 28, 2024

@srawlins now that dart-lang/sdk#33459 is fixed, can this issue be resolved?

from file.dart.

srawlins commented on April 28, 2024

I think it was only partially blocked by dart-lang/sdk#33459. On Dart 2.0.0-dev.69.5 I still get 364 failing tests.

from file.dart.

pq commented on April 28, 2024

Some more context carried over from #103:

See: https://travis-ci.org/google/file.dart/jobs/414381120

A few changes get us most of the way there:

PathContextCodec =>

static path.Context _decode(Map<String, dynamic> input) {

and

static const Converter<Map<String, dynamic>, path.Context> deserialize =
      const _ForwardingConverter<Map<String, dynamic>, path.Context>(_decode);

but someone who understands the source should look a little closer.

FYI @srawlins

from file.dart.

pq commented on April 28, 2024

@srawlins if you make the changes above to PathContextCodec you're down to 8 failures that all look like:

type 'List<dynamic>' is not a subtype of type 'List<String>' of 'input'

package:file/src/backends/record_replay/codecs.dart                     ConvertElements.convert
package:file/src/backends/record_replay/replay_proxy_mixin.dart 133:30  _ReplayFileSystemEntity&Object&ReplayProxyMixin.noSuchMethod
package:file/src/interface/directory.dart 38:26                         ReplayDirectory.listSync
test/common_tests.dart 1075:45                                          runCommonTests.<fn>.<fn>.<fn>.<fn>

from file.dart.

tvolkert commented on April 28, 2024

FYI, deep in Fuchsia tasks atm - will have a look when I come up for air.

from file.dart.

pq commented on April 28, 2024

NP. Thanks! Off next week myself but happy to pitch in when I get back.

from file.dart.

pq commented on April 28, 2024

w/ 65556d8, we're down to 8 failures and 363 passing tests.

from file.dart.

Recommend Projects