Python json_fhir_string_to_proto raises wrong exception type about fhir HOT 2 CLOSED

You're welcome. Thank you for looking into this!

from fhir.

Hey @gitpushdashf 👋

Within codes, we should be raising an instance of fhir_errors.InvalidFhirError, which would be more informative to the user that their provided code string cannot convert to an accompanying FHIRProto EnumValueDescriptor. Making this change properly throws an instance of fhir_errors.InvalidFhirError for your provided example (thank you for a great example btw 🙂). I merged this internally, so expect this fix in the next release.

As an aside, I've also filed a bug internally to review our error handling for google-fhir. I suspect there might be other places where a similar change should take place. I'm hoping to strike a good balance between raising ValueErrors (and other built-in exceptions) where it makes sense, and only relying on propagating fhir_errors.InvalidFhirError, where it's useful to let a caller know that "your JSON is correct, but it's not valid FHIR".

Thank you again!

from fhir.