Git Product home page Git Product logo

Comments (7)

rbrush avatar rbrush commented on May 6, 2024 1

Circling back here: we found the root cause: essentially our use of the "json_name" annotation on one of the FHIR data types is colliding with an additional check in the protobuf 4.x library -- so we need to change how we generate and protobufs and parse FHIR JSON into them.

The change is relatively straightforward (but not trivial) and we'll get to that after wrapping up an unrelated change in flight, so I think we can have this fixed in the next week or two.

from fhir-py.

rbrush avatar rbrush commented on May 6, 2024

Hi Rob, we'll look into it and report back, probably later this week. I suspect this may be related to protocolbuffers/protobuf#12525, which we can try working around by regenerating the FHIR protos with the appropriate option there.

-Ryan

from fhir-py.

rob-pomelo avatar rob-pomelo commented on May 6, 2024

thanks so much ryan, appreciate it!

from fhir-py.

rob-pomelo avatar rob-pomelo commented on May 6, 2024

great to hear, thank you for the update!

from fhir-py.

rbrush avatar rbrush commented on May 6, 2024

A quick update: the compatibility issue turned out to be a bit more involved than anticipated, but we have a targeted fix in the works and should push something in the next couple days.

from fhir-py.

rbrush avatar rbrush commented on May 6, 2024

The updated code should work with the Python protobuf 4.x libraries now.

Note that this will require using protoc >= 3.19, which isn't easily available on the current Ubuntu long-term support release used via GitHub actions (and many production systems), so I'm keeping the protobuf verison pinned in the 3.x range in this repository itself. However, if you're able to build this library and use a newer version of protoc, this should now work with the 4.x libraries.

from fhir-py.

rob-pomelo avatar rob-pomelo commented on May 6, 2024

Thank you! I'll give it a try

from fhir-py.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.