Git Product home page Git Product logo

Comments (12)

mikehelmick avatar mikehelmick commented on May 5, 2024 1

The SMS config will need to be in the database and configured on a per-local basis. See #104

from exposure-notifications-verification-server.

mikehelmick avatar mikehelmick commented on May 5, 2024 1

Follow up from previous comment

SMS provider and use should be database driven.
If there is no provider configured, then the dialog shouldn't be shown.

As we go multi-tenant, this is important since it is possible that different "realms" will use different SMS config and some might not use SMS at all.

from exposure-notifications-verification-server.

google-oss-robot avatar google-oss-robot commented on May 5, 2024

@mikehelmick: The label(s) priority/important-soon cannot be applied, because the repository doesn't have them

In response to this:

TL;DR

Add the ability to send verification codes over SMS

https://www.twilio.com/messaging as likely baked in provider. Must be configurable so operator can bring their own credentials.

/kind enhancement
/priority important-soon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

from exposure-notifications-verification-server.

mikehelmick avatar mikehelmick commented on May 5, 2024

One other note - best if the phone numbers don't get stored in the database.

from exposure-notifications-verification-server.

sethvargo avatar sethvargo commented on May 5, 2024

I have some experience with the Twilio API, so I can take this

from exposure-notifications-verification-server.

sethvargo avatar sethvargo commented on May 5, 2024

/assign

from exposure-notifications-verification-server.

sherifkozman avatar sherifkozman commented on May 5, 2024

Twilio has a some considerations to be noted if it is used for an impelemntation that is not in the US.
i.e : Creating a Numeric or Alpha Numeric Sender ID would be a requirement in some destinations and verifying that the server would use those values when posting a payload.
https://support.twilio.com/hc/en-us/articles/223133767-International-support-for-Alphanumeric-Sender-ID

from exposure-notifications-verification-server.

sethvargo avatar sethvargo commented on May 5, 2024

I think that's fine. The server operator would need to take those steps, but I don't think it would affect our code. Can you share more about your concerns?

from exposure-notifications-verification-server.

sherifkozman avatar sherifkozman commented on May 5, 2024

I am only noting that the Sender ID (i.e numeric or alpha numeric) is a value that should be factored in when integrating with twilio to ensure portability of the service outside of the US. So it would be set as an ENV variable for example the same way you add Twilio API Key and the application SID. Twilio mostly doesnt handle overriding that value on behalf of the sender.

from exposure-notifications-verification-server.

sethvargo avatar sethvargo commented on May 5, 2024

No no, bad GitHub. That was only part 1 of 1000.

from exposure-notifications-verification-server.

mikehelmick avatar mikehelmick commented on May 5, 2024

/assign

from exposure-notifications-verification-server.

sethvargo avatar sethvargo commented on May 5, 2024

/assign

from exposure-notifications-verification-server.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.