Comments (12)
The SMS config will need to be in the database and configured on a per-local basis. See #104
from exposure-notifications-verification-server.
Follow up from previous comment
SMS provider and use should be database driven.
If there is no provider configured, then the dialog shouldn't be shown.
As we go multi-tenant, this is important since it is possible that different "realms" will use different SMS config and some might not use SMS at all.
from exposure-notifications-verification-server.
@mikehelmick: The label(s) priority/important-soon
cannot be applied, because the repository doesn't have them
In response to this:
TL;DR
Add the ability to send verification codes over SMS
https://www.twilio.com/messaging as likely baked in provider. Must be configurable so operator can bring their own credentials.
/kind enhancement
/priority important-soon
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
from exposure-notifications-verification-server.
One other note - best if the phone numbers don't get stored in the database.
from exposure-notifications-verification-server.
I have some experience with the Twilio API, so I can take this
from exposure-notifications-verification-server.
/assign
from exposure-notifications-verification-server.
Twilio has a some considerations to be noted if it is used for an impelemntation that is not in the US.
i.e : Creating a Numeric or Alpha Numeric Sender ID would be a requirement in some destinations and verifying that the server would use those values when posting a payload.
https://support.twilio.com/hc/en-us/articles/223133767-International-support-for-Alphanumeric-Sender-ID
from exposure-notifications-verification-server.
I think that's fine. The server operator would need to take those steps, but I don't think it would affect our code. Can you share more about your concerns?
from exposure-notifications-verification-server.
I am only noting that the Sender ID (i.e numeric or alpha numeric) is a value that should be factored in when integrating with twilio to ensure portability of the service outside of the US. So it would be set as an ENV variable for example the same way you add Twilio API Key and the application SID. Twilio mostly doesnt handle overriding that value on behalf of the sender.
from exposure-notifications-verification-server.
No no, bad GitHub. That was only part 1 of 1000.
from exposure-notifications-verification-server.
/assign
from exposure-notifications-verification-server.
/assign
from exposure-notifications-verification-server.
Related Issues (20)
- Stats page charts not displaying HOT 3
- change missing actor to common error
- add StatusUnprocessableEntity
- Code claim ratio anomaly detection should factor in overall issue volume HOT 9
- Prevent realms from being named "e2e" or similar
- Allow for removal of ENX redirect domains HOT 2
- Exclude certain error codes from SMS anomalies HOT 1
- List metric descriptors and only create missing ones
- Fix column types on sms_configs
- Session cookie too big
- Realm level maintenance mode
- Localized user-report SMS template HOT 2
- strings.Title is deprecated
- Operational Definitions of ENCV Metrics HOT 3
- Is User Report Tokens Claimed a subset of Tokens Claimed? HOT 2
- Upgrade to Firebase 9
- Modeler tests have different results on ARM HOT 2
- SMS Validation and long expires
- v1.16.0 tag points to the same commit as v1.15.0 HOT 3
- system wide verification stats chart broken
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from exposure-notifications-verification-server.