Git Product home page Git Product logo

Comments (3)

ojw28 avatar ojw28 commented on May 4, 2024
  • You should IMO consider DataSource as the common interface that you can plug an arbitrary network stack into. I see little value in defining a more specific HttpInterface under HttpDataSource. You'd likely end up writing nearly as much code adapting an arbitrary network stack onto this interface as you would mapping it onto DataSource directly.
  • I want ManifestFetcher to use DataSource in order to fetch manifests, which would allow your single whatever-network-stack-you-want-DataSource implementation to be used in both places. Right now the DataSource interface doesn't allow querying of content type, which appears to be needed when retrieving manifests. I need to look into that a little bit and see if there are any other implications, but it's probably possible to get that resolved and move over to this way of doing things.

from exoplayer.

ojw28 avatar ojw28 commented on May 4, 2024

So to clarify, I propose using this bug to track having ManifestFetcher use a DataSource.

from exoplayer.

nschwermann avatar nschwermann commented on May 4, 2024

Okay thanks, looking forward to this.
edit: I just saw in the dev guide where you suggest extending DataSource for a custom network stack. My bad :)

from exoplayer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.