Types generation from strings. about error-prone HOT 2 CLOSED

Original comment posted by [email protected] on 2012-08-03 at 10:45 PM

I looked into this a bit. You're right: for plain classes this is easy enough, but when you get into more complex stuff you start rebuilding the parse and attribution phases of the compiler.

What is we provided a TypeBuilder class that lets you build up a type programmatically? So you'd specify something like:
Type t = new TypeBuilder(basetype).setIsArray(true).build();
or
Type t = new TypeBuilder(basetype).setTypeParams(tparam1, tparam2, ...).build();

I would also provide a convenience method for getting simple types like java.lang.Object.

Status: Started
Owner: [email protected]
Labels: Priority-Medium

from error-prone.

Original comment posted by [email protected] on 2012-09-07 at 10:29 PM

I committed a fix in revisions 82ee5e6, f56063d, 0fc2db4, and eaeae92. I provided two new instance methods in VisitorState:
getTypeFromString(typeStr) and getType(baseType, isArray, typeParams)

getTypeFromString returns a Type object from a simple (not an array, not generic) type string (e.g., "java.lang.Object"). It returns null if the compiler has not seen that type yet.

getType lets you construct complex types if you already have the baseType and parameter Types. This lets me avoid parsing a type string. For example, to construct the Type ArrayList<String>, you would do this:
Type baseType = getTypeFromString("java.util.ArrayList");
List<Type> typeParams = new ArrayList<Type>();
typeParams.add(getTypeFromString("java.lang.String");
getType(baseType, false, typeParams);

Status: Fixed
CC: [email protected]

from error-prone.