Release 0.9 has bad tools jar dependency about error-prone HOT 7 CLOSED

Original comment posted by [email protected] on 2012-05-31 at 07:19 PM

This issue was closed by revision b2064e6.

Status: Fixed

from error-prone.

Original comment posted by [email protected] on 2012-05-31 at 09:33 PM

Nope, not fixed. The dependency still leaks out into the deps:
https://oss.sonatype.org/content/repositories/snapshots/com/google/errorprone/error_prone_core/1.0-SNAPSHOT/error_prone_core-1.0-20120531.204659-3.pom

I think that's because the profile is active when the release is performed, which is needed for compilation.
I tried adding <optional>true</optional> but then the maven plugin doesn't work:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.3.2:compile (default-compile) on project guava: Execution default-compile of goal org.apache.maven.plugins:maven-compiler-plugin:2.3.2:compile failed: A required class was missing while executing org.apache.maven.plugins:maven-compiler-plugin:2.3.2:compile: com/sun/source/util/TreePathScanner
[ERROR] -----------------------------------------------------
[ERROR] realm = plugin>org.apache.maven.plugins:maven-compiler-plugin:2.3.2
[ERROR] strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
[ERROR] urls[0] = file:/home/alexeagle/.m2/repository/org/apache/maven/plugins/maven-compiler-plugin/2.3.2/maven-compiler-plugin-2.3.2.jar
[ERROR] urls[1] = file:/home/alexeagle/.m2/repository/com/google/errorprone/error_prone_maven/1.0-SNAPSHOT/error_prone_maven-1.0-SNAPSHOT.jar
[ERROR] urls[2] = file:/home/alexeagle/.m2/repository/com/google/errorprone/error_prone_core/1.0-SNAPSHOT/error_prone_core-1.0-SNAPSHOT.jar
[ERROR] urls[3] = file:/home/alexeagle/.m2/repository/junit/junit/3.8.1/junit-3.8.1.jar
[ERROR] urls[4] = file:/home/alexeagle/.m2/repository/org/codehaus/plexus/plexus-utils/2.0.5/plexus-utils-2.0.5.jar
[ERROR] urls[5] = file:/home/alexeagle/.m2/repository/org/codehaus/plexus/plexus-compiler-api/1.8.1/plexus-compiler-api-1.8.1.jar
[ERROR] urls[6] = file:/home/alexeagle/.m2/repository/org/codehaus/plexus/plexus-compiler-manager/1.8.1/plexus-compiler-manager-1.8.1.jar
[ERROR] urls[7] = file:/home/alexeagle/.m2/repository/org/codehaus/plexus/plexus-compiler-javac/1.8.1/plexus-compiler-javac-1.8.1.jar
[ERROR] Number of foreign imports: 1

Status: Started

from error-prone.

Original comment posted by [email protected] on 2013-02-11 at 07:48 PM

I believe this has been fixed. The pom file now uses the tools.jar from ${java.home}.

Status: Fixed

from error-prone.

Original comment posted by stephan202 on 2013-04-19 at 08:41 PM

Indeed this is supposed to be fixed in 0.9.13, as I can see in the Google Code repository:
https://error-prone.googlecode.com/git-history/v0.9.13/core/pom.xml

BUT... the POM deployed to Maven Central still has the issue:
http://repo1.maven.org/maven2/com/google/errorprone/error_prone_core/0.9.13/error_prone_core-0.9.13.pom

It seems to me that the tagged code is not what's deployed. In fact, the following command shows many other differences as well:
vimdiff <(wget -q -O- 'https://error-prone.googlecode.com/git-history/v0.9.13/core/pom.xml') <(wget -q -O- 'http://repo1.maven.org/maven2/com/google/errorprone/error_prone_core/0.9.13/error_prone_core-0.9.13.pom')

Am I missing something?

from error-prone.

Original comment posted by [email protected] on 2013-04-20 at 05:57 AM

Hmm... it appears when you build the release POM, it substitutes the JAVA_HOME on the build machine for the variable in the XML file.

Alex, do you have time to look at this?

Status: Accepted

from error-prone.

Original comment posted by [email protected] on 2013-04-20 at 08:42 PM

The problem is that mvn:release resolves all variables, to make the build reproducible. That means the interpolated expressions are expanded to the value they had on your machine. I haven't found the maven best practice for this yet.

from error-prone.

Original comment posted by aeagle22206 on 2013-08-12 at 09:08 PM

This was fixed by making the tools.jar dependency <optional>true.
It triggers a maven bug: that optional causes downstream projects to fail to compile, so they need to declare the tools.jar dep again.

Status: Fixed

from error-prone.