Git Product home page Git Product logo

Comments (5)

tirodkar avatar tirodkar commented on April 27, 2024

@bootstraponline, thanks for bringing this to our attention. As per our investigation - the warnings mentioned in #52 can be removed by following the suggestions - turning __FILE__ to #file, __LINE__ to #line and Selector to #selector.

For the build breakages, in GREYActions and GREYMatchers, we were able to remove them by moving the @end from after the c-function definitions at the very end of the file, to right before where we define #if !(GREY_DISABLE_SHORTHAND). Essentially, we need to move the C-functions outside the interface definition. Similarly with the typedef in GREYElementMatcherBlock. Please do test these out and tell us if you still see these issues.

We're planning to send in a Pull Request for these and add them to the next release framework for CocoaPods.

from earlgrey.

bootstraponline avatar bootstraponline commented on April 27, 2024

Thanks for the quick response! I will try the fixes tomorrow and let you know how it goes.

from earlgrey.

bootstraponline avatar bootstraponline commented on April 27, 2024

I confirm that the recommended fixes resolve the build problems. The swift tests are now passing.

ios_tests_fixed

from earlgrey.

tirodkar avatar tirodkar commented on April 27, 2024

Awesome. We'll send a fix for this along with some tests before closing this issue. Thanks for confirming this @bootstraponline.

from earlgrey.

tirodkar avatar tirodkar commented on April 27, 2024

Fixed in #67.

from earlgrey.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.