Update from 3.0 to 3.1 breaks vcpkg build about double-conversion HOT 6 CLOSED

I will try to give it a look.
If you have more information on what would need to be done (or what went wrong) I would appreciate. I don't have any Windows machine, nor do I use this build-system, so debugging things could be complicated for me.

from double-conversion.

The same thing happens on Linux. What I think is wrong, is that double-conversion.h thinks its containing folder's parent will be in the include path, and that it can reference it via double-conversion/utils.h. I think that just utils.h would work [better].

The include paths provided is C:\Dev\vcpkg\installed\x64-windows-static\include\double-conversion, but C:\Dev\vcpkg\installed\x64-windows-static\include is not. See my post.

from double-conversion.

I just had a quick look, and seems related to missing the target include directory for the install tree?

https://github.com/google/double-conversion/blob/master/CMakeLists.txt#L25-L27

target_include_directories(
    double-conversion PUBLIC
$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}>)

that should have a

$<INSTALL_INTERFACE:${include_dir_at_install}>)

but maybe that's added into the logic later, not sure.

from double-conversion.

I'm sorry I still haven't found the time to look at this. It's still on my list, though.

from double-conversion.

Fixed by microsoft/vcpkg#5115.

from double-conversion.

aah. Thanks. Even better :)

from double-conversion.