Comments (5)
I will see if setting the default to false always works.
In the meantime, here is how to test it (from memory):
Create two files and compile them separately:
// div.c
double Div_double(double x, double y) { return x / y; }
// main.c
double Div_double(double x, double y);
int main(int argc, char** argv) {
return Div_double(89255.0, 1e22) == 89255e-22;
}
Compile them separately and link the o-files.
./main || echo "correct"
should now tell you whether the conversion is correct.
If you get "correct" as result, we can just add the new architectures to the "good" list; otherwise to the "bad" list.
If all tests pass, that should be enough.
from double-conversion.
Thanks for the quick feedback. I can run the tests, but I only have access to Qemu emulation for those architecctures ? Is it a good enough test or do you need a test on real hardware ?
from double-conversion.
Ideally I would test on real hardware, but I assume that the emulator does the right thing. (Otherwise programs wouldn't work).
from double-conversion.
Added double-conversion support for the Qt5 (bundled double-converison library) buildroot cross-compile (aarch64_be [1], or1k [2][3], microblazeel/microblazebe [4]) lately, see the links for the
corresponding architecture defines and (qemu only) Div_double tests...
[1] http://lists.busybox.net/pipermail/buildroot/2018-August/227675.html
[2] http://lists.busybox.net/pipermail/buildroot/2018-August/228151.html
[3] http://lists.busybox.net/pipermail/buildroot/2018-August/228150.html
[4] http://lists.busybox.net/pipermail/buildroot/2018-August/228543.html
from double-conversion.
Thanks.
I updated the header.
Note that the file had already changed, and that your (@pseiderer ) patches will now be conflicting.
from double-conversion.
Related Issues (20)
- A comment remained from V8 but not related here
- How to "install" built libraries on Windows HOT 4
- make-ing library on Windows 10 HOT 11
- Maximum string length DoubleToStringConverter::EcmaScriptConverter() ToShortest? 26 chars? HOT 8
- kMaxFixedDigitsAfterPoint should be increased from 60 to 100 HOT 2
- StringToDoubleConverter::StringToDouble slower than dtoa HOT 3
- `StringToDoubleConverter::StringTo<FloatingPoint>` member function templates HOT 3
- Add generic (template) methods for `to_string` (float or double). HOT 2
- New tag/version since 2019? HOT 2
- [bug] ieee.h: Wrong QuietNaN bit check on mips* architectures HOT 1
- Kindly add installation of Windows debugger files (pdb)? HOT 5
- FastFixedDtoa incorrect rounding. HOT 1
- Fix -Wzero-as-null-pointer-constant warnings HOT 12
- Tag a v3.2.1 release? HOT 2
- Various warnings compiling with visual studio HOT 1
- Insecure API when using in React Native iOS app HOT 1
- Set GitHub Workflow permissions to read only HOT 1
- [vulnerability] CVE issues HOT 4
- Hash Pin Github Owned Actions HOT 3
- Enable OpenSSF Scorecard Action and Badge HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from double-conversion.