Architecture detection in utils.h is missing some cases for non-GCC compilation about double-conversion HOT 9 CLOSED

The missing check is actually for _POWER or _ARCH_PPC which are the only macros defined by older versions of gcc on AIX (4.5.2 in this case).

from double-conversion.

According to gcc -dM -E - </dev/null, _POWER would work for me; as would _ARCH_PPC (32 bit) and _ARC_PPC64 (64 bit).

from double-conversion.

If you can confirm that the tests work in these configurations I'm happy to add the defines.

from double-conversion.

We have been running a local version with the added check for _POWER or _ARCH_PPC since october with success.

from double-conversion.

I know it's nearly impossible to make everybody happy. The predef project ( http://sourceforge.net/p/predef/wiki/Architectures/ ) has done a lot of the hard work, but I can't blame you if you want to avoid adding a dependency.

It's probably not clear that ruoso and I work at the same place. I can verify that the project we work on does look for #defines for _POWER and _ARC_PPC, and the library builds and works correctly.

from double-conversion.

Fixed in b8c24a6.

from double-conversion.

Thank you. Unfortunately, I misspelled ARCH_PPC and ARCH_PPC64 more than once (I dropped the 'H'), so I feel a need to report a one-character bug fix.

from double-conversion.

Sorry for the late reply (was marked as non-important...)
Should be fixed now.

from double-conversion.

I'm sorry for the typo! But thank you.

from double-conversion.