cmake scripts currently broken? about double-conversion HOT 5 OPEN

I believe the only change in the cmake files were adding GNUIntsallDirs support by @heirecka but I thought that the changes were backwards compatible.

That said, I have no problem bumping the minimal version if that solves the issue. Should we just do that?

from double-conversion.

After having a second look, it's clear to me that bumping the version number won't just do it. (I was looking at the wrong file, and was confused by the error message).

Adding the missing cmake_minimum_required should be trivial. That would get rid of the warning.
The error itself seems to come from the new code that Heiko added. Hopefully he is still active and knows what to do. I will wait a few days to give him time to respond.

from double-conversion.

From the warning I and the path of the error message I assume you're not in the root dir of the repo. Also the root CMakeLists.txt has "cmake_minimum_required(VERSION 2.8.12)" which is enough to contain GNUInstallDirs (introduced with 2.8.5).
Not starting in the root dir, doesn't include GNUInstallDirs, which causes the error. It could be added to double-conversion/CMakeLists.txt as well, but I'm not sure this actually works for other reasons.

from double-conversion.

Using cmake for me only built the *.a file, and no .so file. Is there an implied [or missing] step to build the shared object using CMake?

Here's the last message seen:

Linking CXX static library libdouble-conversion.a
[100%] Built target double-conversion

from double-conversion.

Using cmake for me only built the *.a file, and no .so file. Is there an implied [or missing] step to build the shared object using CMake?

-DBUILD_SHARED_LIBS:BOOL=TRUE

from double-conversion.