Git Product home page Git Product logo

Comments (7)

srawlins avatar srawlins commented on April 28, 2024

Not sure what to do about this one. My opinion is that it should complain about every short description (especially at the class level), and devs shouldn't worry about hitting 100% doc coverage.

from dart-shapeshift.

pq avatar pq commented on April 28, 2024

As a fan of short comments, I tend to agree FWIW.

Where's the logic for this analysis BTW? I was expecting to see it here?

from dart-shapeshift.

srawlins avatar srawlins commented on April 28, 2024

Sorry, @pq, it should be there, but its in an older bit of code. I'm working on cleaning up the internals as we speak :)

from dart-shapeshift.

srawlins avatar srawlins commented on April 28, 2024

In general, I would like to make the doc coverage tool configurable, so you can leave out certain complaints. That might be a ways off :)

from dart-shapeshift.

pq avatar pq commented on April 28, 2024

Cool. Thanks for the pointer. Configurability is a tough one. Hopefully you won't need too much of it.

In this case, it's interesting. If I'm reading this right, you're minimum is 2 lines? Curious how well the SDK fares against this standard. I'm thinking getters in particular would commonly have just one line.

from dart-shapeshift.

srawlins avatar srawlins commented on April 28, 2024

That should just be for "top-level" comments (for classes and libraries, not methods).

from dart-shapeshift.

pq avatar pq commented on April 28, 2024

Aha. That's better! :)

In the long run, I should get a handle on the exact rules so we can codify the appropriate ones in the linter as well. Anyway, we can connect on that down the road.

Thanks!

from dart-shapeshift.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.