Comments (7)
Not sure what to do about this one. My opinion is that it should complain about every short description (especially at the class level), and devs shouldn't worry about hitting 100% doc coverage.
from dart-shapeshift.
As a fan of short comments, I tend to agree FWIW.
Where's the logic for this analysis BTW? I was expecting to see it here?
from dart-shapeshift.
Sorry, @pq, it should be there, but its in an older bit of code. I'm working on cleaning up the internals as we speak :)
from dart-shapeshift.
In general, I would like to make the doc coverage tool configurable, so you can leave out certain complaints. That might be a ways off :)
from dart-shapeshift.
Cool. Thanks for the pointer. Configurability is a tough one. Hopefully you won't need too much of it.
In this case, it's interesting. If I'm reading this right, you're minimum is 2 lines? Curious how well the SDK fares against this standard. I'm thinking getter
s in particular would commonly have just one line.
from dart-shapeshift.
That should just be for "top-level" comments (for classes and libraries, not methods).
from dart-shapeshift.
Aha. That's better! :)
In the long run, I should get a handle on the exact rules so we can codify the appropriate ones in the linter as well. Anyway, we can connect on that down the road.
Thanks!
from dart-shapeshift.
Related Issues (19)
- Support for automating API change detection (a feeler) HOT 4
- Make a reusable `shapeshift_lib`. HOT 7
- Wrap DiffNode with a nicer interface
- Great tool!
- Live view: Map diff from 1.8.5 to 1.9.3 shows wonky formatting
- Live view: ArgumentError diff from 1.8.5 to 1.9.3 shows wonky formatting HOT 1
- New method code blocks are... ugly
- New method code block comments are... also ugly
- "Paginate" the version list
- Wrong subclasses difference HOT 1
- If a positional argument is renamed, don't call it a remove + add
- Boolean properties (like "abstract") that flip should be noted in one line
- Missing top-level functions and variables HOT 6
- json_diff: path dependency to /Users/srawlins/dart/json_diff HOT 1
- Need to score library-level comments.
- Bold Roboto (like Class names in coverage scores) looks terrible. HOT 1
- Clicking "See" the gaps harangs the badge HOT 1
- No coverage score for Typedefs HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dart-shapeshift.