Compiler error when a component's nested type has the same simple name as a provided type about dagger HOT 11 OPEN

I'm not great at javawriter, yet, so this might be a red herring.

It seems that JavaWriter.sourceReferenceForClassName or JavaWriter.isImported could be made aware of the types visible as they are a nested type in a super, using the canonical name in that case.

https://github.com/google/dagger/blob/master/compiler/src/main/java/dagger/internal/codegen/writer/JavaWriter.java#L249

from dagger.

I'm not sure I can unravel how to fix this quickly, so I've updated w/ a failing test in case someone else can.

from dagger.

Seems like the same or similar to
square/javapoet#77
On Jan 2, 2015 10:12 PM, "Adrian Cole" [email protected] wrote:

I'm not sure I can unravel how to fix this quickly, so I've updated w/ a
failing test in case someone else can.

—
Reply to this email directly or view it on GitHub
#98 (comment).

from dagger.

Great! Ok I will try porting that fix.

I know dagger will move to normal javawriter, but a fix will help progress
until then.

from dagger.

port didn't dodge the issue. I've updated with simpler test cases which show at least 2 ways this can happen.

from dagger.

Good tests - it's been some time and the code has been re-written in places - can you try this with current snapshots and see if it's still failing?

from dagger.

sure

from dagger.

sorry to report that this is still the case.

from dagger.

Hey, sorry it took me a while to get to this. This looks really good. Thanks! A few nits here and there, but if we can get it fixed up, we can get it in for the ‡ release (real soon now!).

from dagger.

This has been languishing for faaaar too long. I will verify that this is either fixed and released or apply the fix.

from dagger.

Still broken at head.

from dagger.