Git Product home page Git Product logo

Comments (8)

gk5885 avatar gk5885 commented on April 28, 2024

I totally agree. @cgruber did the conversion. Christian, can you take a look here?

from dagger.

cgruber avatar cgruber commented on April 28, 2024

Thats confusing to me as they compiled when I ran them, but I'll confirm
and fix.

On Tue, Dec 2, 2014, 09:30 Gregory Kick [email protected] wrote:

Assigned #87 https://github.com/google/dagger/issues/87 to @cgruber
https://github.com/cgruber.


Reply to this email directly or view it on GitHub
https://github.com/google/dagger/issues/87#event-201373368.

from dagger.

nguyentruongtho avatar nguyentruongtho commented on April 28, 2024

With default profile, they will compile but with android profile, it will not because of the error reported above, see https://github.com/google/dagger/blob/master/examples/pom.xml#L32-L49. android-activity-graphs is not compilable.

from dagger.

liminal avatar liminal commented on April 28, 2024

How could the version of the sample code in github master possibly compile?
Look at for instance https://github.com/google/dagger/blob/master/examples/android-activity-graphs/src/main/java/com/example/dagger/activitygraphs/ui/HomeActivity.java#L26
where the refrenced field is never declared.

from dagger.

nguyentruongtho avatar nguyentruongtho commented on April 28, 2024

@liminal It is not hard to fix this compilation issue, I think the maintainers are busy. Meanwhile, you can checkout my fix here #93.

from dagger.

mgrzechocinski avatar mgrzechocinski commented on April 28, 2024

You can also checkout my sample project https://github.com/mgrzechocinski/dagger2-example

from dagger.

EverybodyKurts avatar EverybodyKurts commented on April 28, 2024

Yes, I ran into this problem as well! This is my first taste of Dagger and while I know Dagger 2 hasn't been officially released yet, I was scratching my head as to what I was possibly doing wrong. @nguyentruongtho, @mgrzechocinski I'll take a look at your sample projects and see if I can get further.

from dagger.

cgruber avatar cgruber commented on April 28, 2024

Largely addressed in #93 and #145

from dagger.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.