Git Product home page Git Product logo

Comments (13)

radzio avatar radzio commented on April 28, 2024

+1

from dagger.

alexandru-calinoiu avatar alexandru-calinoiu commented on April 28, 2024

+1

from dagger.

artem-zinnatullin avatar artem-zinnatullin commented on April 28, 2024

πŸ‘Ž Dagger 2 is not ready for non SNAPSHOT release, as we all can see because of issues like #108 mentioned by @mgrzechocinski which are breaking the API.

I agree, that Dagger team can release snapshot with versioning according to Semantic Versioning v2.0.0 , it will be great.

If you want stability from SNAPSHOT β€” download jars from mavenCentral and put them into your projects, don't let your build system to change things on the fly.

from dagger.

sleroux avatar sleroux commented on April 28, 2024

+1 Had an issue with the latest push to snapshot - still trying to boil it down into a simple example for an issue request...

from dagger.

JakeWharton avatar JakeWharton commented on April 28, 2024

No. If you don't want a snapshot version to break your code then don't depend on it. There's plenty of other safe, hermetic ways to get Dagger 2 into your app. This is a terrible request to make.

from dagger.

mgrzechocinski avatar mgrzechocinski commented on April 28, 2024

What are the "other safe and hermetic ways to get Dagger2 into your app"? Hope you won't ask us to keep Dagger2 jar within source code like in old 90ies...

I'm not against developing software under SNAPSHOT in overall. It's extremely useful in some situations, especially when working on multi-module apps. I also know, that depending on a SNAPSHOT might break my code, I'm aware of it.

I just think that Dagger2, as feature completed library is no longer a SNAPSHOT and should be released with fixed versions, so that real projects (=not simple examples) which can give you a real feedback won't break after ones push new version. Alpha, Beta, RC, there are plenty of classifiers to use until releasing as final v2.0.

from dagger.

JakeWharton avatar JakeWharton commented on April 28, 2024

Why do you think it's feature complete? Features are landing in every sync from Google's internal repo.

from dagger.

mgrzechocinski avatar mgrzechocinski commented on April 28, 2024

I pointed to Gregory's presentation when opening this request and also trying to be up to date with the latest commits.

from dagger.

JakeWharton avatar JakeWharton commented on April 28, 2024

I'll tell the next pull request to watch the presentation. Deploy a jar to your internal artifact repository or check it in temporarily. These types of issues is what makes people burn out on open source and should be closed with extreme prejudice.

from dagger.

mgrzechocinski avatar mgrzechocinski commented on April 28, 2024

I watched it and because I used Dagger1 a lot, I decided to switch to v2.

Frankly, what makes me personally burnt out on OS is trying to help by giving feedback from a real project and failing it under random&unclear circumstances just because you can't use 0.x, Alpha, Beta or any other versioning rule, saying "don't depend on it".

I'll check-in previous JAR version, feeling like in ANT times. EOT for me.

from dagger.

JakeWharton avatar JakeWharton commented on April 28, 2024

Who said "don't depend on it"? If you depend on a snapshot, you have explicitly opted in to breaking changes without notice. Stop blaming others and just fix your build.

from dagger.

tbroyer avatar tbroyer commented on April 28, 2024

@mgrzechocinski How about using timestamped snapshots [1] with a repository manager (to make sure it's not pruned from the repository; you set your own strategy rather than relying on the Sonatype OSS one)
Or you can β€œfork” and release/deploy non-snapshots you can rely on (or snapshots under your own coordinates; the idea being that you choose when you update).

[1] Maven has mvn versions:lock-snapshots, there might be equivalent plugins for Gradle (maybe nebula.dependency-lock would do it)

from dagger.

cgruber avatar cgruber commented on April 28, 2024

We will be releasing a stable 2.0 shortly.

from dagger.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.