TSAN error when a socket is closed about cppdap HOT 3 CLOSED

void close() {
#if !defined(_WIN32)
   {
     RLock l(mutex);
     if (s != InvalidSocket) {
       ::shutdown(s, SHUT_RDWR);
     }
   }
#endif

   WLock l(mutex);
   if (s != InvalidSocket) {
#if defined(_WIN32)
     closesocket(s);
#else
     ::close(s);
#endif
     s = InvalidSocket;
   }
 }

On windows shutdown() isn't called before closesocket

from cppdap.

I think we should rewrite close function like this.

void close() {
   {
     RLock l(mutex);
     if (s != InvalidSocket) {
#if !defined(_WIN32)
       ::shutdown(s, SHUT_RDWR);
#else
       ::shutdown(s, SD_BOTH);
#endif
     }
   }

   WLock l(mutex);
   if (s != InvalidSocket) {
#if defined(_WIN32)
     closesocket(s);
#else
     ::close(s);
#endif
     s = InvalidSocket;
   }
 }

from cppdap.

I

I think we should rewrite close function like this.

void close() {
   {
     RLock l(mutex);
     if (s != InvalidSocket) {
#if !defined(_WIN32)
       ::shutdown(s, SHUT_RDWR);
#else
       ::shutdown(s, SD_BOTH);
#endif
     }
   }

   WLock l(mutex);
   if (s != InvalidSocket) {
#if defined(_WIN32)
     closesocket(s);
#else
     ::close(s);
#endif
     s = InvalidSocket;
   }
 }

It didn't work even though call shutdown before closesocket on Windows 10. So i have to remove the WLock l(mutex).

from cppdap.