Comments (4)
On the one hand, this is expected behaviour. BoringSSL rejects any RSA public key where e > 33 bits long. See the references in the relevant check for a good background on why. In general, large values of e add computational complexity without adding security, and I believe BoringSSL would have chosen a (slightly) lower limit[1] except 2^32+1 is in use for DNSSEC by some TLDs.
On the other hand, the results you are getting here are buggy. In the first example Signature.initVerify()
should have thrown InvalidKeyException
and in the second Cipher.init()
should have thrown it, so thanks for catching that!
[1] E.g. The Windows struct _RSAPUBKEY
only allows 32 bits for e, so that provides a good upper bound for anything that needs to interoperate with Windows.
from conscrypt.
Actually, thinking about it, the validity checks should probably go on the code paths which create public and private RSA keys either from KeySpec
value constructors as above or PKCS#8 / X.509 encodings.
from conscrypt.
Yeah the validity checks being delayed is a consequence of bad OpenSSL APIs. If you create them from the parser, BoringSSL will check such things eagerly. But if you create from individual components, it's a mess. In a lot of cases, you have to call RSA_check_key. Except that's particularly tricky for Conscrypt because by default, RSA_check_key won't tolerate keys with n and d, but not e.
The new APIs from #1133 resolve this mess. Actually, one of the side effects is that PR + new BoringSSLwill check validity at key creation rather than deferring to use. (Sorry I should have called that out but forgot to.) So that part is all set, for newer BoringSSL. For older BoringSSL, you almost could turn on the RSA_check_key codepath, but you'd have to deal with the n , d thing, so might be easier to just get everything to new BoringSSL. :-/
from conscrypt.
Actually, one of the side effects is that PR + new BoringSSL will check validity at key creation rather than deferring to use
Fab! We probably need some tests on the Conscrypt side (if only to validate the exception thrown), but I can take care of that.
from conscrypt.
Related Issues (20)
- Expired certificate is trusted
- Crash : SIGSEGV /SEGV_MAPERR HOT 22
- are methods connect() and accept() asynchronous in conscrypt? HOT 1
- Certificate verify in conscrypt is not follow RFC2818 HOT 2
- Decrypt conscrypt code
- Additional secure PSK cipher suites
- Need help to understand this point of validating the trust. HOT 2
- signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x10000012c HOT 6
- Virtual thread pinning using Conscrypt with Socket APIs HOT 5
- jmigrate reports errors with org.conscrypt.Platform library HOT 1
- Remove sun.security.x509 dependency
- Can armeabi architecture be supported?
- May I ask how to build Android so files? HOT 2
- OpenSSLX509CRLEntry.hasUnsupportedCriticalExtension shouldn't call X509_supported_extensions HOT 2
- Sangat Berpuas Hati Dengan meneruskan, anda bersetuju Google menggunakan jawapan, maklumat akaun & sistem anda untuk meningkatkan perkhidmatan, mengikut Privasi & Syarat kami . HOT 1
- Native crash with latest BoringSSL HOT 8
- Recommended way to use Pre-Shared Key ?
- OkHttp Websocket connection failing few seconds after getting connected
- RSA "NoPadding" encryption is considered not secure but required by conscrypt to support TLS RSA-PSS signing algorithm HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from conscrypt.