Git Product home page Git Product logo

Comments (7)

gk5885 avatar gk5885 commented on May 7, 2024

So, I like the idea, but there are some issues. JavaFileObject has no notion of file path. You have the full URI (and you may remember the issues with getting the path from that…) and the file contents. That's pretty much it. I don't think that any sort of 2-tier matching is in the works, but a nice list of "These files looked kind of similar" might be really helpful.

from compile-testing.

cgruber avatar cgruber commented on May 7, 2024

Oh... right - it's the class name, not the path that goes into it. Hmm. That sucks. I guess I don't care so much about the mechanism, as much as the outcome, and yeah, the similarity list might work well.

from compile-testing.

JakeWharton avatar JakeWharton commented on May 7, 2024

This just bit me hard for about 45m. Had to debug through a few times to realize the file path had no relevance and a typo in generated source was causing the failure.

You have the full URI (and you may remember the issues with getting the path from that…)

Is there an explanation here that's relatively brief?

from compile-testing.

gk5885 avatar gk5885 commented on May 7, 2024

The issue with the path is that jar URLs don't have paths in the sense that you'd hope. It would just require special-casing throughout to hand them properly.

from compile-testing.

JakeWharton avatar JakeWharton commented on May 7, 2024

Would package + class name suffice as something to at least do file-based matching?

At the very least, the error message here is misleading and could use a wording change.

from compile-testing.

gk5885 avatar gk5885 commented on May 7, 2024

Oh, yes. Wow. That's a pretty bad message. We should definitely change that.

from compile-testing.

dieend avatar dieend commented on May 7, 2024

Is it possible to actually test again the generated file with another test?

from compile-testing.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.