Git Product home page Git Product logo

Comments (5)

GoogleCodeExporter avatar GoogleCodeExporter commented on May 5, 2024
This may be related - I noticed a number of temp files are not cleaned up on 
the Windows version. This is probably because UnmapViewOfFile does not appear 
to be used, and the handle returned by CreateFileMapping isn't closed. I would 
probably add this info to mmapData and give it a Close() method, which I would 
use right before removing the file.

Original comment by [email protected] on 24 Jan 2012 at 3:39

  • Added labels: ****
  • Removed labels: ****

from codesearch.

GoogleCodeExporter avatar GoogleCodeExporter commented on May 5, 2024
Hahahaha. I decided to try and fix the bugs in the code to make this work. I'm 
still at it. First, the checked in code doesn't compile out of the box anymore, 
due to a missing typecast. That's just the beginning, though. During a simple 
index update, the code generates about a dozen intermediate/temporary files. 
*None* of them are correctly cleaned up. I'm guessing the only reason any of 
this code works at all on *ix systems is due to the lack of file locking. 
Sadly, the code has almost no error checking performed on critical file system 
operations, and none of the abstractions used for file-system objects (Index, 
IndexWriter) even had the ability to close cleanly - they basically only had 
API to open/read/write, with the assumption that the OS would let you call 
Remove on the open file when you were done.

Original comment by [email protected] on 20 May 2012 at 8:03

  • Added labels: ****
  • Removed labels: ****

from codesearch.

GoogleCodeExporter avatar GoogleCodeExporter commented on May 5, 2024
I've attached a patch that fixes this, plus the compile error. It also changes 
the path used to store the index (e.g. use APPDATA instead of HOME environment 
variable)

Original comment by [email protected] on 24 May 2012 at 6:38

  • Added labels: ****
  • Removed labels: ****

Attachments:

from codesearch.

GoogleCodeExporter avatar GoogleCodeExporter commented on May 5, 2024
Thanks - the patch definitely helps - the search index is updated and renamed 
correctly. Two things though - mmap_linux.go needs a copy of unmmapFile, and 
the temporary files generated as a part of the index process are not deleted.

Original comment by [email protected] on 21 Jun 2012 at 6:17

  • Added labels: ****
  • Removed labels: ****

from codesearch.

GoogleCodeExporter avatar GoogleCodeExporter commented on May 5, 2024
This patch seems to get the temp files deleted.

Original comment by [email protected] on 22 Jun 2012 at 8:05

  • Added labels: ****
  • Removed labels: ****

Attachments:

from codesearch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.