Comments (6)
Improving error messages will save developers and Clspv maintainers time. For example, it should take far less time to get to root cause of issues such as #11
from clspv.
It seems there's some attempt to have friendly errors via a plugin ASTFrontendAction , but it doesn't seem effective.
https://github.com/google/clspv/blob/master/tools/driver/main.cpp#L126
from clspv.
Well, the checker does work. But the clspv build process eliminates all the declarations of vectors longer than 4 elements. So something like float8 x() { return (float8)(1.0); }
will think float8 is an undefined type.
Then as per tradition, 'int' is substitued for the return type, and the extra semantic checks on vector type just pass.
So that's why the action seems somewhat ineffective.
from clspv.
Yeah we ended up removing the 8 and 16 wide vector elements because the clang frontend took too long compiling with all the extra function declarations. The ability to use the plugin to clang to do other frontend warnings for the tool seemed useful so I left it in.
from clspv.
Absolutely. I now have a patch that puts those long decls back in, but just the extended vector typedefs. And a small tweak to the plugin will get us emitting errors again.
from clspv.
See #16
Now we will error out in a more friendly way when unsupported vector types are used inside function bodies.
from clspv.
Related Issues (20)
- Implement sampler mask using uniform buffer instead of push constant
- SimplifyPointerBitcast performs wrong simplification HOT 1
- math functions issue since instcombine transform "and" pattern to call to fabs HOT 1
- Invalid word count when emitting OpConstant HOT 3
- Segmentation fault HOT 1
- OpAtomicUMax may have the wrong pointer type after cast + offset HOT 1
- Temporary Bugfix: SimplifyPointerBitcastPass emits faulty IR that loses OpLoads of 16 bit fields HOT 2
- ReplacePointerBitcastPass introduces invalid IR with struct field of a struct HOT 3
- migrate from deprecated Type::isOpaquePointerTy() to Type::isPointerTy() HOT 1
- Ternary operator on AMD vk drivers. HOT 3
- Segmentation fault with conditional pointer assignment from different address spaces HOT 4
- Canonicalization of GEPs to i8 HOT 10
- Constant initialized global variable rewrites produce invalid IR
- Handle LLVM intrinsic llvm.is_fpclass
- Loads of i32s are fragmented into 4 bytes HOT 3
- how can I cross compile clspv in x86 for risc-v HOT 1
- Loads and Stores of i32s from offset addresses are fragmented HOT 1
- Loads and Stores from offset addresses are fragmented HOT 5
- Implement compatibility for external LLVM-IL HOT 15
- Clspv Fragments access to global memory by the Smallest access size
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from clspv.