Git Product home page Git Product logo

Comments (6)

dneto0 avatar dneto0 commented on April 27, 2024

Improving error messages will save developers and Clspv maintainers time. For example, it should take far less time to get to root cause of issues such as #11

from clspv.

dneto0 avatar dneto0 commented on April 27, 2024

It seems there's some attempt to have friendly errors via a plugin ASTFrontendAction , but it doesn't seem effective.
https://github.com/google/clspv/blob/master/tools/driver/main.cpp#L126

from clspv.

dneto0 avatar dneto0 commented on April 27, 2024

Well, the checker does work. But the clspv build process eliminates all the declarations of vectors longer than 4 elements. So something like float8 x() { return (float8)(1.0); } will think float8 is an undefined type.
Then as per tradition, 'int' is substitued for the return type, and the extra semantic checks on vector type just pass.
So that's why the action seems somewhat ineffective.

from clspv.

sheredom avatar sheredom commented on April 27, 2024

Yeah we ended up removing the 8 and 16 wide vector elements because the clang frontend took too long compiling with all the extra function declarations. The ability to use the plugin to clang to do other frontend warnings for the tool seemed useful so I left it in.

from clspv.

dneto0 avatar dneto0 commented on April 27, 2024

Absolutely. I now have a patch that puts those long decls back in, but just the extended vector typedefs. And a small tweak to the plugin will get us emitting errors again.

from clspv.

dneto0 avatar dneto0 commented on April 27, 2024

See #16
Now we will error out in a more friendly way when unsupported vector types are used inside function bodies.

from clspv.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.