testLocalPrintingToggle() Failure about cloudprint_logocert HOT 5 CLOSED

Marc,

We made some changes to testcert.py, is this still an issue?

from cloudprint_logocert.

Kelly,

Unfortunately, this is still not fixed.

I'm inserting our previous original email thread regarding this issue below for more information:

Marc: My second concern is the testLocalPrintingToggle(). This test failed. The failure was on testcert.py:2108. It failed since it was trying to find the change button or (destination-settings-change-button) that does not exists. I believe the fix for this is, we should call chrome.Print() first before calling this line:
testcert.py:2108: found = chrome.SelectPrinterFromPrintDialog(self.printer, localprint=True)

Kelly: For the 2nd issue, it shouldn't be calling chrome.Print() first, as the change button is not related to printing. When you're looking at the screen, do you see the Change button?

Marc: The change button can be seen in the chrome "print dialog". Since we already closed the print dialog at line 2100 of testcert.py, the function chrome.SelectPrinterFromPrintDialog(self.printer, localprint=True) in line 2108 of testcert.py failed because it is expecting the "print dialog" to be there.

Kelly: Marc, Ok, I understand better now. Please file an issue on GitHub and I'll address it there:

Hope this helps.

Thanks,
Marc

from cloudprint_logocert.

Hello Kelly,

Do you have an update on this?

Thanks!

from cloudprint_logocert.

I think the fix here is simply to put chrome.print() in line 2107. I've made the change, so please verify if this works.

from cloudprint_logocert.

This is now fixed.

Thanks

from cloudprint_logocert.