Setting `autoescape` on a template causes the template to silently fail. about closure-templates HOT 10 CLOSED

I should add, the version we are using is "com.google.template" % "soy" % "2015-04-10".

from closure-templates.

Just to say we're seeing this behaviour too.

We're trying to upgrade to the latest version (2015-04-10) and as we've previously been using noAutoescape in a couple of places wanted to be able to set the autoescaping to the old behaviour (i.e. contextual). Setting autoescape on either the individual template or namespace doesn't seem to work.

from closure-templates.

I believe that you now need to set it to "deprecated-contextual",

On Mon, Jun 29, 2015, 7:07 AM John Montgomery [email protected]
wrote:

Just to say we're seeing this behaviour too.

We're trying to upgrade to the latest version (2015-04-10) and as we've
previously been using noAutoescape in a couple of places wanted to be able
to set the autoescaping to the old behaviour (i.e. contextual). Setting
autoescape on either the individual template or namespace doesn't seem to
work.

—
Reply to this email directly or view it on GitHub
#44 (comment)
.

from closure-templates.

Ah that worked!

Digging in I see those values seem to be defined here:

https://github.com/google/closure-templates/blob/e049b2e673a5a9571aaa088f4c6d2d434d444d7b/java/src/com/google/template/soy/soytree/AutoescapeMode.java

So the valid values for autoescape would seem to be:

• deprecated-noautoescape
• deprecated-noncontextual
• deprecated-contextual
• strict

So I guess the main bug really is not getting an error when autoescape doesn't match one of those valeus. That and the documentation not matching. It still references true/false/contextual in these locations:

• https://developers.google.com/closure/templates/docs/commands#namespace
• https://developers.google.com/closure/templates/docs/commands#template
• https://developers.google.com/closure/templates/docs/security#contextual

Just mentioning this here, as someone else might find it useful.

I don't seem to see the docs in the Repo here - otherwise I'd ask if you want them updated...

Anyway, thanks again for the info. Saved quite a bid of head scratching...

cheers,

John

from closure-templates.

I think I may have fixed the poor error message issue in
19c61de

I think you are just on an earlier release (sorry!).

Thanks for the pointer about the docs, I'll try to get those fixed

from closure-templates.

OK, glad to hear it's fixed and you're on top of the docs.

Guess they'll be a new release soonish?

from closure-templates.

@Ubehebe is in charge of maven/github pushes

from closure-templates.

re docs, it looks like there is an effort underway to convert all our existing docs to markdown and (eventually) get them into this repository. so updating the docs may take a while :(

from closure-templates.

....two months later the docs are updated. Sorry, I just lost track of this.

from closure-templates.

Hey it's done at least! Thank you.

from closure-templates.