Git Product home page Git Product logo

Comments (6)

iflan avatar iflan commented on April 27, 2024
Could you please upload this to codereview.appspot.com? Things are not configured to
ingest contributions yet, but I will try my best.

In general, it would be easiest to follow the instructions on http://code.google.com/p/closure-compiler/wiki/Contributors,
though http://code.google.com/p/closure-library/wiki/Contributors has more detailed
instructions for using codereview.appspot.com.

Reported by [email protected] on 2011-12-02 22:15:12

from closure-stylesheets.

iflan avatar iflan commented on April 27, 2024

Reported by [email protected] on 2011-12-02 22:15:41

  • Labels added: Type-Enhancement
  • Labels removed: Type-Defect

from closure-stylesheets.

iflan avatar iflan commented on April 27, 2024
OK. I'll clean a little the code (it's a little dirty and I've idea to do it better)
and when it's good I'll upload on codereview. I think it will be available in the next
days.

Reported by Yves.Brissaud on 2011-12-06 09:00:53

from closure-stylesheets.

iflan avatar iflan commented on April 27, 2024
Here is the patch uploaded to codereview : http://codereview.appspot.com/5468048/

I've update many things from the first patch (linked to this issue). Essentially by
adding some HSL functions (Luminance is used to have a lighter / darker color).
Some tests has been written and the issue contains a little test case to see the usage
of those functions.

Hope this can be usefull

Reported by Yves.Brissaud on 2011-12-08 20:14:00

from closure-stylesheets.

iflan avatar iflan commented on April 27, 2024

@eunomie, I believe that this was your original issue and patch. If you're still interested, can you make a pull request with the updated patch? Yes, I know, it's been nearly 4 years, so if you don't care to, I completely understand. Just say so and I'll close out this bug.

from closure-stylesheets.

eunomie avatar eunomie commented on April 27, 2024

Thanks for reporting my old issue :-)

See #66 for the PR.

from closure-stylesheets.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.