Git Product home page Git Product logo

Comments (7)

dschuyler avatar dschuyler commented on May 19, 2024

Not that I'm aware of. It's an area that needs some attention.

Note: While looking at the code referenced below, you may start to wonder "how does this work?": the answer is that it doesn't. The current code is a mix of two versions of handling colors that haven't been cleaned up/fixed. What follows is a description of how it was intended to work, but doesn't currently work.

Code:
The color scheme stuff is in ci_edit/app/default_prefs.py, roughly lines 100-300 and lines 1180-1220. (or search for 'color8 = ' and ' "palette":').

The (intended) way for a user to change the color scheme (to "dark" for example) is to edit
"~/.ci_edit/prefs/editor.json" with text like:

{
        "colorScheme": "dark"
}

That is (or should, if it wasn't broken) be handled in ci_edit/app/ci_program.py within setUpPalette(self).

There's also an option to specify
"~/.ci_edit/prefs/editor.json":

{
        "colorScheme": "custom"
}

and provide a custom palette in "~/.ci_edit/prefs/color_scheme.json".

from ci_edit.

dschuyler avatar dschuyler commented on May 19, 2024

Would you like me to fix the current color design or are you thinking of reworking the code so much that fixing the existing code wouldn't help?

from ci_edit.

0xPrateek avatar 0xPrateek commented on May 19, 2024

Actually, I have thought a couple of ways to change the color scheme. You have explained the current color scheme implementation very well and now I can better think on my implementation method (Thanks.. :) )

  • How the user will be able to change the color scheme
    1 - By using some shortcut keys; like we have ctrl+s for saving. we can also have some specific keys related to some default color scheme and thus the user can change the color scheme directly from the terminal just it will reload the editor once.
    2- The second method is by creating a configuration file specifically for the custom color scheme which will be a script and it does what you said that it should do manually.
    we can choose either of the ways.. 👍

from ci_edit.

0xPrateek avatar 0xPrateek commented on May 19, 2024

I just want to know that if that feature of changing the color scheme is not UP and you aren't working on it then can i work on to improve ci_edit?

from ci_edit.

dschuyler avatar dschuyler commented on May 19, 2024

I'll assign this bug to you to show that you're working on it.

from ci_edit.

0xPrateek avatar 0xPrateek commented on May 19, 2024

Great ..!

from ci_edit.

seasonedfish avatar seasonedfish commented on May 19, 2024

Any progress on this? I would love to have dark themes so that opening the editor in a dark-themed terminal would not be so jarring.

from ci_edit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.