Aspect Ratio not taken into account about cameraview HOT 14 CLOSED

Because it is not one of the supported aspect ratios. We will figure out how to deliver errors properly. For now, please make sure to use CameraView#getSupportedAspectRatios before setting an aspect ratio.

from cameraview.

@yaraki so if we always want our camera view to be a square but the camera doesn't support a 1:1 ratio, what's your recommended way to achieve this?

Actually, after doing some testing I think this may still be a bug. Im using this in my layout file:

<com.google.android.cameraview.CameraView
    android:id="@+id/camera"
    android:layout_width="match_parent"
    android:layout_height="wrap_content"
    android:keepScreenOn="true"
    android:adjustViewBounds="true"
    app:autoFocus="true"
    app:aspectRatio="1:1"
    app:facing="back"
    app:flash="auto"/>

And the ratio that actually displays on Nexus 5X with Nougat is about 3:4. If I retrieve the supported ratios after the camera is opened usinggetSupportedAspectRatios(), 1:1 is one of them, so it seem like the camera actually supports it. If I then try to set it programmatically using cameraView.setAspectRatio() the camera view gets the right size but stops displaying the preview.

from cameraview.

I'll investigate.

from cameraview.

Couldn't you just put the CameraView inside a square parent? Something like this:

public class SquareRelativeLayout extends RelativeLayout {

    public SquareRelativeLayout(Context context, AttributeSet attrs) {
        super(context, attrs);
    }

    @Override
    protected void onMeasure(int widthMeasureSpec, int heightMeasureSpec) {
        // Or use heightMeasureSpec
        super.onMeasure(widthMeasureSpec, widthMeasureSpec);
    }
}

from cameraview.

That will crop the CameraView to square size, but the taken pictures will not be square.

This is a combination of 2 issues. I'm working on a fix.

• Aspect Ratio is not working properly.
• Nexus 5X reports 1:1 ratio as one of the supported picture format, but the preview crashes with SurfaceView.

from cameraview.

@yaraki Do you have any update on this ?

from cameraview.

Not yet. I'm working on it.

from cameraview.

I added aspect ratio choice in the demo app. Also, setAspectRatio now works after layout. I still need to fix the issue with 1:1 on N5x and such.

from cameraview.

Nexus 6P, Android Nougat, 1:1 aspect ratio is ignored.
getSupportedAspectRatios() returns empty set

from cameraview.

I get the same issue with nexus 5x android nougat/O. can't get a 1:1 setting it with a setAspectRatio call after layout. Is there an update to this problem?

from cameraview.

I had the same issue and basically you need to set the aspect ratio after the camera has been initialized in this function

private CameraView.Callback mCallback
            = new CameraView.Callback() {

        @Override
        public void onCameraOpened(CameraView cameraView) {
            Set s = mCameraView.getSupportedAspectRatios(); // This is just to make sure the set is not empty
            mCameraView.setAspectRatio(AspectRatio.of(1,1));
        }

from cameraview.

Do you guys have a fix on the issue? Have white background appearing on my Nexus 5x running Android 8 on 16:9 preview. All other phone I tested running ok. Thanks.

from cameraview.

could not achieve aspect ratio 1:1 on Nokia 6

from cameraview.

Do you guys have a fix on the issue? Have white background appearing on my Nexus 5x running Android 8 on 16:9 preview. All other phone I tested running ok. Thanks.

Hey can you help me. i'm recording the video on full screen but when i preview this video it not plays in full screen why ?

from cameraview.