Comments (4)
uInt8ArrayToStr
at the end of compressStr
should not be used. Result of compression is byte array. It can be even, it can be odd length. Moreover, JS is allowed to replace characters it does not understand with placeholders -> compressed data will be corrupted.
Fixed code is here: https://stackblitz.com/edit/node-5zrzir?file=index.js
from brotli.
Here is an example that I got, but I doubt its correctness. It often throws an error Uncaught RangeError: byte length of Uint16Array should be a multiple of 2 at new Uint16Array
. So don't use it.
import { compress, decompress } from "brotli-compress";
function strToUint8Array(str: string) {
const codeUnits = Uint16Array.from(
{ length: str.length },
(element, index) => str.charCodeAt(index)
);
return new Uint8Array(codeUnits.buffer);
}
function uInt8ArrayToStr(bytes: Uint8Array) {
const charCodes = new Uint16Array(bytes.buffer);
let result = "";
charCodes.forEach((char) => {
result += String.fromCharCode(char);
});
return result;
}
export async function compressStr(str: string) {
if (str.length === 0) {
return "";
}
const bytes = strToUint8Array(str);
const compressStr = await compress(bytes);
return uInt8ArrayToStr(compressStr);
}
export async function decompressStr(compressStr: string) {
if (compressStr.length === 0) {
return "";
}
const compressBytes = strToUint8Array(compressStr);
const decompressBytes = await decompress(compressBytes);
return uInt8ArrayToStr(
decompressBytes
);
}
from brotli.
"brotli-compress" is a third party module, so I can only guess.
Brotli compressor is byte-oriented, i.e. it takes (U)Int8Array
for input and produces (U)Int8Array
as output.
Indeed, internally JS stores strings as UTF-16, but there is no reason to compress UTF-16 data. Brotli does much better work in UTF-8.
Your code snippet looks well. Could you provide a sample that causes the error?
from brotli.
@eustas The error occurs if you run the following code:
const result = await compressStr("test test");
from brotli.
Related Issues (20)
- Support for user-supplied dictionaries in Python binding
- Release v1.1 HOT 14
- Publish JNI artefacts (including platform-dependent) HOT 7
- Stale comment referring to nonexisting WriteMetadata() function HOT 6
- v1.1.0rc does not build on macOS 10.12.6 HOT 8
- Strange compression ratio on large CSV file... HOT 1
- Brotli v1.1.0 tests fail with pypy3 HOT 10
- Brotli 1.1.0 breaks Python 2 compatibility HOT 3
- Create a static source tarball for releases
- CMake build broken, tries to install man files in /man not in CMAKE_INSTALL_PREFIX
- bazel error no such package '@org_brotli// HOT 4
- Brotli 1.1.0 NginX HOT 3
- Brotli 1.1.0 changed return values? HOT 5
- [Feature Request] adding a option to control whether install the executable HOT 4
- makefile broken HOT 7
- undefined symbol BrotliEncoderDestroyPreparedDictionary HOT 5
- Windows ARM64EC Target Fails - _tzcnt_u64(EC Symbol) HOT 4
- CMake compile error on Debian bookworm HOT 1
- 1.0.9 used to build static libraries - where have they gone?
- Kotlin Multiplatform HOT 11
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from brotli.