Field slider should inherit parent block if shadow about blockly-samples HOT 5 CLOSED

I'm not sure that we actually want to do this, because it only applies to zelos. The dropdown field handles this by using a special constant in the zelos renderer sets to true. We could use the same flag to trigger the functionality in the slider field, but it sucks that the constant is prefixed with FIELD_DROPDOWN, and not something more generic.

from blockly-samples.

This happens in all the renderers, not just Zelos, because all the renderers use the block's color as the background for the slider div. So in this case there is no need to use the FIELD_DROPDOWN_COLOURED_DIV value. We could have chosen to do so in the beginning if we wanted the slider to be white in thrasos and colorful in zelos, to match the dropdown field, but that would be a behavior change since currently it always has a colored background.

from blockly-samples.

I think what I was concerned about is that in other renderers, the shadow block (and its color) are actually shown. So I think it makes sense to make the dropdown div the color of the shadow block in those cases:

As opposed to zelos, which does not show the shadow block if the only element of the block is the field:

Where it definitely does make sense to use the color of the parent block.

I guess the question is whether you think it makes sense in the first case for the background of the slider to be green or not.

from blockly-samples.

Huh. Since most of the shadow blocks are numbers I never noticed they have their own colors haha. I thought they were all gray...

In that case, I think you're right that we shouldn't change this. In Zelos you cannot tell the difference between a shadow block and a real block visually, so the shadow block should behave the same as the real block IMO. If it would be blue when you drop a real block in, it should probably be blue before that as well. That seems least surprising.

The original screenshot looks incorrect, but it would be the exact same behavior if the slider block is a "real" block instead of a shadow, so I think that's more of a problem with zelos in general than this specific behavior.

wdyt? i'm fine to just close this if you agree.

from blockly-samples.

Agree, closing.

from blockly-samples.