[Win Build] Incorrect PostgreSQL path configuration about binexport HOT 4 CLOSED

Yeah, some of those FindXXX modules are quite inconsistent. Though the behavior you encountered seems to be working as intended, I suppose. Does the build work for you if you just omit the PostgreSQL-related arguments to the CMake command-line? Because that'd be the ideal case -- CMake just finds everything it needs.

from binexport.

No, without them (and that was my original problem which triggered this issue) CMake selected the default PostgreSQL installation, with the build later failing:

LINK : fatal error LNK1181: cannot open input file 'C:\Program Files (x86)\PostgreSQL\9.5\lib\intl.lib'

But, looking now at my PostgreSQL installation, version 9.5 (the docs suggests to download a previous one), I see that (potentially) the same library exist but as libintl.lib, so maybe this is just a naming issue.

from binexport.

It appears that there is no other way to force FindPostgreSQL to reliably accept path overrides. So I guess your solution to add to CMAKE_FIND_ROOT_PATH is sensible. Re-rooting the search tree in this case isn't as bad as it sounds, though, as we're deliberately shipping/installing third-party dependencies in third_party.

from binexport.

Added your workaround. Marking as fixed.

from binexport.