Comments (4)
EricWF
commented on May 5, 2024
Urg, std::is_trivially_destructible is the cause of a lot of pain. I think we can safely just remove the static_assert in walltime.cc though. I don't think that Walltime::now() is used at all during program termination.
I'll submit a patch that removes the static_assert.
from benchmark.
dmah42
commented on May 5, 2024
We might. If StartTimer is called by a thread during termination we might try to access it.
A better fix would be to allocate the WallTimeImp on the heap as a pointer and never free it.
from benchmark.
mathieuk
commented on May 5, 2024
So, what would be the best way to move this forward?
from benchmark.
EricWF
commented on May 5, 2024
This has already been fixed. Please reopen if you disagree.
from benchmark.
Related Issues (20)
- [BUG] Result of run with --benchmark_list_tests=true may not show on console
- [FR] JSON AoS<->SoA redesign HOT 6
- Migrate to bzlmod HOT 9
- [BUG] 1.8.3: build fails with gcc 14.x HOT 4
- [FR] Add `CMake` option to disable `benchmark_main` target HOT 2
- [BUG] Weird behavior of bytes_per_second and items_per_second HOT 8
- [FR] cp312 release on pypi
- [BUG] Reported iterations per run when using repetitions always the same value? HOT 3
- [BUG] With NDEBUG, early-returning without SkipWithError leads to indefinite retries HOT 5
- Complexity calculation does not work for manual timing
- [FR] Reuse benchmark functions with arbitrary fixture templates
- [FR] BENCHMARK_VERSION is not set by default HOT 4
- [BUG] Iteration count in Report looks suspicious HOT 5
- [Q] Need help with understanding the results HOT 1
- [BUG] benchmark::DoNotOptimize does not prevent a reference from being optimized away. HOT 4
- [FR]disable threads for wasm? HOT 9
- [FR] Remove COMPILER_IBMXL macro for z/OS HOT 4
- [BUG] Fixture test with StrictMock crashed HOT 2
- [BUG] HOT 2
- [FR] possible to stop benchmark loop from doing a memory allocation at the end? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from benchmark.