Comments (3)
I hacked around this by moving the
srcs = depset(transitive = [src.files for src in ctx.attr.srcs]).to_list()
line up to the beginning of _javadoc_library
and adding
+ ":".join([src.path for src in srcs])
to the end of the -sourcepath
.
That probably should filter the join
to only keep paths that end in -src.jar
and/or .srcjar
, or something like that (or directly filter the srcs
attribute somehow)
from bazel-common.
Hmm, I didn't realize that javadoc will process source jars, that's cool.
What about adding a srcjars
attribute to the rule?
from bazel-common.
Hmm, I didn't realize that javadoc will process source jars, that's cool.
The way you call javadoc
here, you don't give it source files, but a pair of packages + source path (see https://docs.oracle.com/javase/8/docs/technotes/tools/unix/javadoc.html)
BTW, I haven't checked (because I haven't had the need), but apparently you pass the packages as a single colon-separated argument, rather than separate arguments, so specifying several values in root_packages
might not work as expected.
What about adding a
srcjars
attribute to the rule?
SGTM
Still feels weird that srcs
is not actually taken into account other than for up-to-date checks, and you actually have to filter your sources through root_packages
and exclude_packages
; doesn't really match how other Bazel rules work AFAICT. Should it be renamed to something else? At a minimum its documentation needs to be changed, as the source files are not processed (e.g. "source files, used solely to determine if the rule is up-to-date; all sources in the given packages will actually be processed")
from bazel-common.
Related Issues (20)
- Keep the Android SDK optional under forthcoming Bazel versions
- See what's up with square/bazel_maven_repository
- jarjar failed handling org.xerial.snappy:snappy-java:1.1.8.2 HOT 5
- jarjar_runner.sh is unreliable on case-insensitive filesystems (Mac) HOT 2
- jarjar_runner.sh fails incorrectly on jars that contain files ending in ~ HOT 1
- Update asm to version 9.2 HOT 7
- Issue running jarjar with a rule file HOT 3
- Cannot set `size` or `timeout` in `gen_java_tests` rule
- More than one javadoc_library rule ends up producing "merged" output
- Security Policy violation Binary Artifacts HOT 3
- javadoc_library doesn't grok tree artifacts HOT 3
- Something something Bzlmod HOT 1
- Release a repository archive for consistent checksum HOT 2
- Some libraries should have deps
- Update asm to version 9.6 (or at least 9.5)
- Update log4j version past 1.2.15.
- Use Bazel CI HOT 1
- Unable to set custom api_level and build_tools_version HOT 2
- Prepare for --incompatible_load_java_rules_from_bzl in Bazel 1.2.1 HOT 3
- gRPC-netty is old, and depends on a broken version of netty
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bazel-common.