functioninfo.h:163 Check failed: logical_num > 0 (0 vs. 0) about autofdo HOT 12 CLOSED

Could you give a reproducible, for example attach the binary and the profile?

from autofdo.

Could you give a reproducible, for example attach the binary and the profile?
Yes! But could you provide me an email address since the zipped file of the binary and the profile still excesses the maximum size supported.

from autofdo.

You can send it to [email protected]. Thanks!

from autofdo.

You can send it to [email protected]. Thanks!

Sent.

from autofdo.

from autofdo.

I met the same problem, has it been solved?

from autofdo.

I solved it by sampling perf.data using perf record -b -e br_inst_retired.near_taken:pp -p 1 -- sleep 120
and complie with -g option in the first compilation, and remove the -g option in the second compilation

https://gcc.gnu.org/onlinedocs/gcc/Optimize-Options.html ， and search key word autofdo

from autofdo.

I also meet this problem, when convert redis profiling data to .gcov. Is there any solution?

from autofdo.

from autofdo.

Hi all, I also meet this problem and solved it by compare with old create_gcov.
little example can recurrence this problem:

#include <iostream>
#include <stdlib.h>
inline int foobar(int a, int b)
{
  if (a < b)
    return a;
  a = rand();
  b = rand();
  return a-b;
}

int bar(int a) {
  a+=rand();
  return a;
}

int foo(int a, int b)
{
  return bar(foobar(a,b));
}

int main()
{
  int a = 1;
  int j = 10000000;
  while (j--)
    a+= foo(rand(),rand());
  std::cout << a << endl;
  return 0;
}

The solution is:

--- a/legacy_addr2line.cc
+++ b/legacy_addr2line.cc
@@ -184,6 +184,9 @@ void Google3Addr2line::GetInlineStack(uint64_t address,
   if (iter == line_map_->begin())
     return;
   --iter;
+  if (iter->second == 0) {
+    return;
+  }
   const LineIdentifier &LI = line_map_->GetLogical(iter->second);
   if (LI.line == 0)
     return;

hope it`s useful ^_^

from autofdo.

Thanks for pointing that out! I somehow dropped that line when I was doing the merge. The suggested fix solves the problem. Will merge it.

from autofdo.

Fix committed: 8d5bf56

from autofdo.