Git Product home page Git Product logo

Comments (7)

cclauss avatar cclauss commented on May 2, 2024 1

Some remaining issues... Fixed in #228, #229, #230, #231

flake8 testing of https://github.com/google/apitools on Python 3.6.3

$ flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics

./ez_setup.py:94:41: E999 SyntaxError: invalid syntax
    except pkg_resources.VersionConflict, e:
                                        ^
./apitools/base/protorpclite/messages.py:482:20: F821 undefined name 'cmp'
            return cmp(self.number, other.number)
                   ^
./apitools/base/protorpclite/messages_test.py:132:48: F821 undefined name 'long'
            self.assertEquals(Color.RED, Color(long(20)))
                                               ^
./apitools/base/protorpclite/messages_test.py:1041:47: F821 undefined name 'long'
            messages.IntegerField(10, default=long(10))
                                              ^
./samples/storage_sample/downloads_test.py:174:31: E999 SyntaxError: invalid syntax
            print 'Progress %s' % download_object.progress
                              ^
2     E999 SyntaxError: invalid syntax
3     F821 undefined name 'cmp'
5

from apitools.

kevinli7 avatar kevinli7 commented on May 2, 2024

The tests currently run under multiple python versions including python 3 versions.

https://github.com/google/apitools/blob/master/tox.ini

from apitools.

tvalentyn avatar tvalentyn commented on May 2, 2024

That's great! Do we have any concerns about adding a Python3 language classifiers to setup.py to explicitly state Python3 support?

from apitools.

tvalentyn avatar tvalentyn commented on May 2, 2024

Actually looks like Codebase is not fully Python3-complient, and there are some PRs in flight, for example: #214.

from apitools.

kevinli7 avatar kevinli7 commented on May 2, 2024

There may be a few bugs related, but this code base is largely python3 compliant. #214 looks to be a PR made by a non-contributor and the changes in that pull are no longer relevant.

from apitools.

tvalentyn avatar tvalentyn commented on May 2, 2024

FYI: BEAM-5788 shows that GCS api calls in google-apitools don't work on Python 3. Based on the feedback I've received so far, google-apitools is not officially supported, and google-api-python-client or something in the google-cloud family of libraries should be used instead, so I don't have an expectation that this issue will be fixed.

from apitools.

cclauss avatar cclauss commented on May 2, 2024

Despite BEAM's readiness, can #228, #229, #230, #231 still be reviewed?

from apitools.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.