Git Product home page Git Product logo

Comments (8)

pau-baiget avatar pau-baiget commented on May 5, 2024

@johnplate could you please take a look at this one, please?

from agi.

johnplate avatar johnplate commented on May 5, 2024

@AWoloszyn Did you mean "if WAIT_ALL was not set"?
And there is no "infinite" defined for this function. Do we want to define a threshold for an "infinite" duration?

from agi.

AWoloszyn avatar AWoloszyn commented on May 5, 2024

Sorry, to be more clear.
If the timeout is not SUFFICIENTLY LONG* (where sufficiently long is defined as: both the trace and replay NEVER hit the timeout)

And if WAIT_ALL is NOT set. If wait_all is not set, then the returns may not be the same in replay.

from agi.

AWoloszyn avatar AWoloszyn commented on May 5, 2024

I do also consider UINT64_MAX nanoseconds to be sufficiently close to infinity that we typically treat it as such. Unlikely someone will be running for 500+ yrs

from agi.

yalcinmelihyasin avatar yalcinmelihyasin commented on May 5, 2024

Do we get any information, if the fence wait stopped because of a signaling e.g vkQueueSubmit or timeout?

Why don't we wait as duration of timeout variable?

from agi.

pau-baiget avatar pau-baiget commented on May 5, 2024

Lowering priority since it's not a blocker but still keeping it to P2 since we need to revisit this in the future.

from agi.

AWoloszyn avatar AWoloszyn commented on May 5, 2024

I would be worried about dropping the priority,
VkWaitForFences(VkDevice, VkFence, 42)
will simply not replay correctly (reliably)

from agi.

yalcinmelihyasin avatar yalcinmelihyasin commented on May 5, 2024

This has been fixed with #430

from agi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.