Add a helper func so that people can do something like goacm

Started working on this in <a href="https://go-review.googlesource.com/23970" rel="nof

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

ListenAndServeTLS about acme HOT 4 CLOSED

google commented on July 22, 2024

ListenAndServeTLS

from acme.

Comments (4)

bradrydzewski commented on July 22, 2024

a slightly alternative approach would be to provide a custom implementation of net.Listener. This would allow you to do something like this:

tlsListener := goacme.NewListener(...)

s := &http.Server{Addr: addr, Handler: handler}
s.Serve(tlsListener)

or like this:

tlsListener := goacme.NewListener(...)
http.Serve(tlsListener, handler)

this might be a bit more flexible than my original proposal to implement a custom ListenAndServerTLS

from acme.

x1ddos commented on July 22, 2024

Started working on this in https://go-review.googlesource.com/23970

from acme.

x1ddos commented on July 22, 2024

I have successfully ran a static file server using the CL 23970 referenced above. My program was:

package main

import (
    "crypto/tls"
    "log"
    "net/http"

    "golang.org/x/crypto/acme/internal/manager"
)

func main() {
    dir := http.Dir(".")
    http.Handle("/", http.FileServer(dir))

    var man manager.Manager
    getcert := func(hello *tls.ClientHelloInfo) (*tls.Certificate, error) {
        log.Printf("hello: %s", hello.ServerName)
        cert, err := man.GetCertificate(hello)
        if err != nil {
            log.Printf("mananger: %v", err)
        }
        return cert, err
    }

    s := &http.Server{
        Addr:      ":https",
        TLSConfig: &tls.Config{GetCertificate: getcert},
    }
    go func() {
        if err := s.ListenAndServeTLS("", ""); err != nil {
            log.Fatalf("serve TLS: %v", err)
        }
    }()

    if err := http.ListenAndServe(":http", nil); err != nil {
        log.Fatalf("serve http: %v", err)
    }
}