[Idea] Provide inset aware layouts about accompanist HOT 11 CLOSED

I don't know if adding custom composables of already existing ones is a good idea. That would require alot of maintanance in the future. If Scaffold is changed, so will InsetAwareScaffold have to change.

Wouldn't a simple modifier that applies the insets to the any Composable? Something like .padding(WindowInsets) or applyWindowInsets()

from accompanist.

If Scaffold is changed, so will InsetAwareScaffold have to change.

Compose’s API is now API stable, so there won’t be any API changes. Also, this library isn’t designed to live forever.

Wouldn't a simple modifier that applies the insets to the any Composable? Something like .padding(WindowInsets) or applyWindowInsets()

We already have that: https://google.github.io/accompanist/insets/

from accompanist.

From what I remember in Flutter, only the Scaffold was insets aware, and it passed those insets to its children. So maybe that's how it should be done in here as well?

from accompanist.

Sure, but we're not copying Flutter, or being limited to what Flutter provides.

from accompanist.

I have made a PR for this.

from accompanist.

Please no, that feels like adding unnecessary bloat (a little rude, excuse me). I don't want to have many theme / styles / layout implementations, that's a past thing which in my opinion shouldn't be added (remember multiple application themes, in my opinion there's just has to be one - DayNight and that's it etc...)

from accompanist.

Please no, that feels like adding unnecessary bloat (a little rude, excuse me).

I get not wanting to bloat the main library, but this would be in an optional insets-layouts library (if we did it).

from accompanist.

from accompanist.

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

from accompanist.

The issue is still relevant.

from accompanist.

Oh, thank you!

from accompanist.