Git Product home page Git Product logo

Comments (34)

RamiroPinol avatar RamiroPinol commented on May 23, 2024 2

Hi everyone,

Just to add info to this thread, I was able to build and test successfully on MacOS Catalina (10.15) only with gcc 9.2.

brew reinstall gcc
mkdir build && cd build
CXX=g++-9 cmake -DPython_TARGET_VERSION=3.7.2 -DCMAKE_CXX_COMPILER=${CXX} ../open_spiel
make -j12
ctest -j12

from open_spiel.

alexminnaar avatar alexminnaar commented on May 23, 2024 1

@lanctot yes I saw that - I just mentioned that in case this user was using an older version. But yes as of now it should be just build.

from open_spiel.

lanctot avatar lanctot commented on May 23, 2024

Hmm.. looks like you're using clang (not g++?) Can you tell me precisely what commands you ran before the make command?

Did you try Step 3 of the summary installation instructions, i.e. that just runs ./open_spiel/scripts/build_and_run_tests.sh ?

from open_spiel.

allychina avatar allychina commented on May 23, 2024

Hmm.. looks like you're using clang (not g++?) Can you tell me precisely what commands you ran before the make command?

Did you try Step 3 of the summary installation instructions, i.e. that just runs ./open_spiel/scripts/build_and_run_tests.sh ?

I did exactly the summary installation steps:

  1. download and ./install.sh ---done
    2.virtualenv -p python3 venv
    source venv/bin/activate
    pip3 install -r requirements.txt
    -----done
    3../open_spiel/scripts/build_and_run_tests.sh ----have problem like this

53% tests passed, 44 tests failed out of 94

Total Test time (real) = 206.99 sec

The following tests FAILED:
49 - python_api_test (Failed)
50 - python_playthrough_test (Failed)
51 - python_action_value_vs_best_response_test (Failed)
52 - python_best_response_test (Failed)
53 - python_cfr_test (Failed)
54 - python_deep_cfr_test (Failed)
55 - python_dqn_test (Failed)
56 - python_eva_test (Failed)
57 - python_evaluate_bots_test (Failed)
58 - python_expected_game_score_test (Failed)
59 - python_exploitability_descent_test (Failed)
60 - python_exploitability_test (Failed)
61 - python_fictitious_play_test (Failed)
62 - python_generate_playthrough_test (Failed)
63 - python_get_all_states_test (Failed)
65 - python_lp_solver_test (Failed)
66 - python_mcts_test (Failed)
67 - python_minimax_test (Failed)
68 - python_nfsp_test (Failed)
69 - python_outcome_sampling_mccfr_test (Failed)
70 - python_policy_gradient_test (Failed)
72 - python_generalized_psro_test (Failed)
73 - python_rectified_nash_response_test (Failed)
74 - python_random_agent_test (Failed)
75 - python_rcfr_test (Failed)
76 - python_sequence_form_lp_test (Failed)
77 - python_value_iteration_test (Failed)
78 - python_bluechip_bridge_wrapper_test (Failed)
79 - python_uniform_random_test (Failed)
80 - python_alpharank_test (Failed)
81 - python_alpharank_visualizer_test (Failed)
82 - python_dynamics_test (Failed)
83 - python_heuristic_payoff_table_test (Failed)
84 - python_utils_test (Failed)
85 - python_visualization_test (Failed)
86 - python_catch_test (Failed)
87 - python_cliff_walking_test (Failed)
88 - python_data_test (Failed)
89 - python_bot_test (Failed)
90 - python_games_sim_test (Failed)
91 - python_matrix_game_utils_test (Failed)
92 - python_policy_test (Failed)
93 - python_pyspiel_test (Failed)
94 - python_rl_environment_test (Failed)

more imformation:
7/94 Test #58: python_expected_game_score_test .............***Failed 0.65 sec
Traceback (most recent call last):
File "/Users/ally/open_spiel-master/open_spiel/python/../python/algorithms/expected_game_score_test.py", line 24, in
from open_spiel.python import policy
File "/Users/ally/open_spiel-master/open_spiel/python/policy.py", line 40, in
import pyspiel
ImportError: dlopen(/Users/ally/open_spiel-master/build/python/pyspiel.so, 2): Symbol not found: _PyThread_tss_alloc
Referenced from: /Users/ally/open_spiel-master/build/python/pyspiel.so
Expected in: flat namespace
in /Users/ally/open_spiel-master/build/python/pyspiel.so

  Start 63: python_get_all_states_test

8/94 Test #63: python_get_all_states_test ..................***Failed 0.13 sec
Traceback (most recent call last):
File "/Users/ally/open_spiel-master/open_spiel/python/../python/algorithms/get_all_states_test.py", line 24, in
import pyspiel
ImportError: dlopen(/Users/ally/open_spiel-master/build/python/pyspiel.so, 2): Symbol not found: _PyThread_tss_alloc
Referenced from: /Users/ally/open_spiel-master/build/python/pyspiel.so
Expected in: flat namespace
in /Users/ally/open_spiel-master/build/python/pyspiel.so

  Start 65: python_lp_solver_test

9/94 Test #61: python_fictitious_play_test .................***Failed 0.53 sec
Traceback (most recent call last):
File "/Users/ally/open_spiel-master/open_spiel/python/../python/algorithms/fictitious_play_test.py", line 23, in
from open_spiel.python import policy
File "/Users/ally/open_spiel-master/open_spiel/python/policy.py", line 40, in
import pyspiel
ImportError: dlopen(/Users/ally/open_spiel-master/build/python/pyspiel.so, 2): Symbol not found: _PyThread_tss_alloc
Referenced from: /Users/ally/open_spiel-master/build/python/pyspiel.so
Expected in: flat namespace
in /Users/ally/open_spiel-master/build/python/pyspiel.so

  Start 66: python_mcts_test

10/94 Test #62: python_generate_playthrough_test ............***Failed 0.50 sec
Traceback (most recent call last):
File "/Users/ally/open_spiel-master/open_spiel/python/../python/algorithms/generate_playthrough_test.py", line 23, in
from open_spiel.python.algorithms import generate_playthrough
File "/Users/ally/open_spiel-master/open_spiel/python/algorithms/generate_playthrough.py", line 28, in
import pyspiel
ImportError: dlopen(/Users/ally/open_spiel-master/build/python/pyspiel.so, 2): Symbol not found: _PyThread_tss_alloc
Referenced from: /Users/ally/open_spiel-master/build/python/pyspiel.so
Expected in: flat namespace
in /Users/ally/open_spiel-master/build/python/pyspiel.so

  Start 67: python_minimax_test

11/94 Test #60: python_exploitability_test ..................***Failed 0.81 sec
Traceback (most recent call last):
File "/Users/ally/open_spiel-master/open_spiel/python/../python/algorithms/exploitability_test.py", line 24, in
from open_spiel.python import policy
File "/Users/ally/open_spiel-master/open_spiel/python/policy.py", line 40, in
import pyspiel
ImportError: dlopen(/Users/ally/open_spiel-master/build/python/pyspiel.so, 2): Symbol not found: _PyThread_tss_alloc
Referenced from: /Users/ally/open_spiel-master/build/python/pyspiel.so
Expected in: flat namespace
in /Users/ally/open_spiel-master/build/python/pyspiel.so

  Start 68: python_nfsp_test

12/94 Test #67: python_minimax_test .........................***Failed 0.13 sec
Traceback (most recent call last):
File "/Users/ally/open_spiel-master/open_spiel/python/../python/algorithms/minimax_test.py", line 23, in
from open_spiel.python.algorithms import minimax
File "/Users/ally/open_spiel-master/open_spiel/python/algorithms/minimax.py", line 27, in
import pyspiel
ImportError: dlopen(/Users/ally/open_spiel-master/build/python/pyspiel.so, 2): Symbol not found: _PyThread_tss_alloc
Referenced from: /Users/ally/open_spiel-master/build/python/pyspiel.so
Expected in: flat namespace
in /Users/ally/open_spiel-master/build/python/pyspiel.so

  Start 69: python_outcome_sampling_mccfr_test

13/94 Test #65: python_lp_solver_test .......................***Failed 0.56 sec
Traceback (most recent call last):
File "/Users/ally/open_spiel-master/open_spiel/python/../python/algorithms/lp_solver_test.py", line 24, in
from open_spiel.python.algorithms import lp_solver
File "/Users/ally/open_spiel-master/open_spiel/python/algorithms/lp_solver.py", line 24, in
import pyspiel
ImportError: dlopen(/Users/ally/open_spiel-master/build/python/pyspiel.so, 2): Symbol not found: _PyThread_tss_alloc
Referenced from: /Users/ally/open_spiel-master/build/python/pyspiel.so
Expected in: flat namespace
in /Users/ally/open_spiel-master/build/python/pyspiel.so

  Start 70: python_policy_gradient_test

14/94 Test #66: python_mcts_test ............................***Failed 0.57 sec
Traceback (most recent call last):
File "/Users/ally/open_spiel-master/open_spiel/python/../python/algorithms/mcts_test.py", line 26, in
from open_spiel.python.algorithms import evaluate_bots
File "/Users/ally/open_spiel-master/open_spiel/python/algorithms/evaluate_bots.py", line 21, in
import pyspiel
ImportError: dlopen(/Users/ally/open_spiel-master/build/python/pyspiel.so, 2): Symbol not found: _PyThread_tss_alloc
Referenced from: /Users/ally/open_spiel-master/build/python/pyspiel.so
Expected in: flat namespace
in /Users/ally/open_spiel-master/build/python/pyspiel.so

  Start 72: python_generalized_psro_test

15/94 Test #69: python_outcome_sampling_mccfr_test ..........***Failed 0.57 sec
Traceback (most recent call last):
File "/Users/ally/open_spiel-master/open_spiel/python/../python/algorithms/outcome_sampling_mccfr_test.py", line 23, in
from open_spiel.python import policy
File "/Users/ally/open_spiel-master/open_spiel/python/policy.py", line 40, in
import pyspiel
ImportError: dlopen(/Users/ally/open_spiel-master/build/python/pyspiel.so, 2): Symbol not found: _PyThread_tss_alloc
Referenced from: /Users/ally/open_spiel-master/build/python/pyspiel.so
Expected in: flat namespace
in /Users/ally/open_spiel-master/build/python/pyspiel.so

  Start 73: python_rectified_nash_response_test

16/94 Test #72: python_generalized_psro_test ................***Failed 0.94 sec
Traceback (most recent call last):
File "/Users/ally/open_spiel-master/open_spiel/python/../python/algorithms/psro_variations/generalized_psro_test.py", line 25, in
from open_spiel.python.algorithms.psro_variations import generalized_psro
File "/Users/ally/open_spiel-master/open_spiel/python/algorithms/psro_variations/generalized_psro.py", line 40, in
from open_spiel.python.algorithms.psro_variations import abstract_meta_trainer
File "/Users/ally/open_spiel-master/open_spiel/python/algorithms/psro_variations/abstract_meta_trainer.py", line 26, in
from open_spiel.python.algorithms import lp_solver
File "/Users/ally/open_spiel-master/open_spiel/python/algorithms/lp_solver.py", line 24, in
import pyspiel
ImportError: dlopen(/Users/ally/open_spiel-master/build/python/pyspiel.so, 2): Symbol not found: _PyThread_tss_alloc
Referenced from: /Users/ally/open_spiel-master/build/python/pyspiel.so
Expected in: flat namespace
in /Users/ally/open_spiel-master/build/python/pyspiel.so

  Start 74: python_random_agent_test

17/94 Test #73: python_rectified_nash_response_test .........***Failed 1.02 sec
Traceback (most recent call last):
File "/Users/ally/open_spiel-master/open_spiel/python/../python/algorithms/psro_variations/rectified_nash_response_test.py", line 24, in
from open_spiel.python.algorithms.psro_variations import optimization_oracle
File "/Users/ally/open_spiel-master/open_spiel/python/algorithms/psro_variations/optimization_oracle.py", line 29, in
from open_spiel.python.algorithms.psro_variations import abstract_meta_trainer
File "/Users/ally/open_spiel-master/open_spiel/python/algorithms/psro_variations/abstract_meta_trainer.py", line 26, in
from open_spiel.python.algorithms import lp_solver
File "/Users/ally/open_spiel-master/open_spiel/python/algorithms/lp_solver.py", line 24, in
import pyspiel
ImportError: dlopen(/Users/ally/open_spiel-master/build/python/pyspiel.so, 2): Symbol not found: _PyThread_tss_alloc
Referenced from: /Users/ally/open_spiel-master/build/python/pyspiel.so
Expected in: flat namespace
in /Users/ally/open_spiel-master/build/python/pyspiel.so

  Start 75: python_rcfr_test

18/94 Test #74: python_random_agent_test ....................***Failed 0.66 sec
Traceback (most recent call last):
File "/Users/ally/open_spiel-master/open_spiel/python/../python/algorithms/random_agent_test.py", line 23, in
from open_spiel.python import rl_environment
File "/Users/ally/open_spiel-master/open_spiel/python/rl_environment.py", line 57, in
import pyspiel
ImportError: dlopen(/Users/ally/open_spiel-master/build/python/pyspiel.so, 2): Symbol not found: _PyThread_tss_alloc
Referenced from: /Users/ally/open_spiel-master/build/python/pyspiel.so
Expected in: flat namespace
in /Users/ally/open_spiel-master/build/python/pyspiel.so

  Start 76: python_sequence_form_lp_test

19/94 Test #76: python_sequence_form_lp_test ................***Failed 0.68 sec
Traceback (most recent call last):
File "/Users/ally/open_spiel-master/open_spiel/python/../python/algorithms/sequence_form_lp_test.py", line 23, in
from open_spiel.python.algorithms import sequence_form_lp
File "/Users/ally/open_spiel-master/open_spiel/python/algorithms/sequence_form_lp.py", line 32, in
from open_spiel.python import policy
File "/Users/ally/open_spiel-master/open_spiel/python/policy.py", line 40, in
import pyspiel
ImportError: dlopen(/Users/ally/open_spiel-master/build/python/pyspiel.so, 2): Symbol not found: _PyThread_tss_alloc
Referenced from: /Users/ally/open_spiel-master/build/python/pyspiel.so
Expected in: flat namespace
in /Users/ally/open_spiel-master/build/python/pyspiel.so

  Start 77: python_value_iteration_test

20/94 Test #77: python_value_iteration_test .................***Failed 0.14 sec
Traceback (most recent call last):
File "/Users/ally/open_spiel-master/open_spiel/python/../python/algorithms/value_iteration_test.py", line 23, in
from open_spiel.python.algorithms import value_iteration
File "/Users/ally/open_spiel-master/open_spiel/python/algorithms/value_iteration.py", line 22, in
import pyspiel
ImportError: dlopen(/Users/ally/open_spiel-master/build/python/pyspiel.so, 2): Symbol not found: _PyThread_tss_alloc
Referenced from: /Users/ally/open_spiel-master/build/python/pyspiel.so
Expected in: flat namespace
in /Users/ally/open_spiel-master/build/python/pyspiel.so

  Start 78: python_bluechip_bridge_wrapper_test

21/94 Test #78: python_bluechip_bridge_wrapper_test .........***Failed 0.44 sec
Traceback (most recent call last):
File "/Users/ally/open_spiel-master/open_spiel/python/../python/bots/bluechip_bridge_wrapper_test.py", line 24, in
from open_spiel.python.bots import bluechip_bridge_wrapper
File "/Users/ally/open_spiel-master/open_spiel/python/bots/bluechip_bridge_wrapper.py", line 41, in
import pyspiel
ImportError: dlopen(/Users/ally/open_spiel-master/build/python/pyspiel.so, 2): Symbol not found: _PyThread_tss_alloc
Referenced from: /Users/ally/open_spiel-master/build/python/pyspiel.so
Expected in: flat namespace
in /Users/ally/open_spiel-master/build/python/pyspiel.so

  Start 79: python_uniform_random_test

22/94 Test #79: python_uniform_random_test ..................***Failed 0.54 sec
Traceback (most recent call last):
File "/Users/ally/open_spiel-master/open_spiel/python/../python/bots/uniform_random_test.py", line 24, in
from open_spiel.python.bots import uniform_random
File "/Users/ally/open_spiel-master/open_spiel/python/bots/uniform_random.py", line 21, in
import pyspiel
ImportError: dlopen(/Users/ally/open_spiel-master/build/python/pyspiel.so, 2): Symbol not found: _PyThread_tss_alloc
Referenced from: /Users/ally/open_spiel-master/build/python/pyspiel.so
Expected in: flat namespace
in /Users/ally/open_spiel-master/build/python/pyspiel.so

  Start 80: python_alpharank_test

23/94 Test #56: python_eva_test .............................***Failed 8.07 sec
/Users/ally/open_spiel-master/venv/lib/python3.6/site-packages/tensorflow/python/framework/dtypes.py:516: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_qint8 = np.dtype([("qint8", np.int8, 1)])
/Users/ally/open_spiel-master/venv/lib/python3.6/site-packages/tensorflow/python/framework/dtypes.py:517: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_quint8 = np.dtype([("quint8", np.uint8, 1)])
/Users/ally/open_spiel-master/venv/lib/python3.6/site-packages/tensorflow/python/framework/dtypes.py:518: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_qint16 = np.dtype([("qint16", np.int16, 1)])
/Users/ally/open_spiel-master/venv/lib/python3.6/site-packages/tensorflow/python/framework/dtypes.py:519: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_quint16 = np.dtype([("quint16", np.uint16, 1)])
/Users/ally/open_spiel-master/venv/lib/python3.6/site-packages/tensorflow/python/framework/dtypes.py:520: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_qint32 = np.dtype([("qint32", np.int32, 1)])
/Users/ally/open_spiel-master/venv/lib/python3.6/site-packages/tensorflow/python/framework/dtypes.py:525: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
np_resource = np.dtype([("resource", np.ubyte, 1)])
/Users/ally/open_spiel-master/venv/lib/python3.6/site-packages/tensorboard/compat/tensorflow_stub/dtypes.py:541: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_qint8 = np.dtype([("qint8", np.int8, 1)])
/Users/ally/open_spiel-master/venv/lib/python3.6/site-packages/tensorboard/compat/tensorflow_stub/dtypes.py:542: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_quint8 = np.dtype([("quint8", np.uint8, 1)])
/Users/ally/open_spiel-master/venv/lib/python3.6/site-packages/tensorboard/compat/tensorflow_stub/dtypes.py:543: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_qint16 = np.dtype([("qint16", np.int16, 1)])
/Users/ally/open_spiel-master/venv/lib/python3.6/site-packages/tensorboard/compat/tensorflow_stub/dtypes.py:544: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_quint16 = np.dtype([("quint16", np.uint16, 1)])
/Users/ally/open_spiel-master/venv/lib/python3.6/site-packages/tensorboard/compat/tensorflow_stub/dtypes.py:545: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_qint32 = np.dtype([("qint32", np.int32, 1)])
/Users/ally/open_spiel-master/venv/lib/python3.6/site-packages/tensorboard/compat/tensorflow_stub/dtypes.py:550: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
np_resource = np.dtype([("resource", np.ubyte, 1)])
Traceback (most recent call last):
File "/Users/ally/open_spiel-master/open_spiel/python/../python/algorithms/eva_test.py", line 24, in
from open_spiel.python import rl_environment
File "/Users/ally/open_spiel-master/open_spiel/python/rl_environment.py", line 57, in
import pyspiel
ImportError: dlopen(/Users/ally/open_spiel-master/build/python/pyspiel.so, 2): Symbol not found: _PyThread_tss_alloc
Referenced from: /Users/ally/open_spiel-master/build/python/pyspiel.so
Expected in: flat namespace
in /Users/ally/open_spiel-master/build/python/pyspiel.so

  Start 81: python_alpharank_visualizer_test

24/94 Test #59: python_exploitability_descent_test ..........***Failed 6.96 sec
/Users/ally/open_spiel-master/venv/lib/python3.6/site-packages/tensorflow/python/framework/dtypes.py:516: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_qint8 = np.dtype([("qint8", np.int8, 1)])
/Users/ally/open_spiel-master/venv/lib/python3.6/site-packages/tensorflow/python/framework/dtypes.py:517: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_quint8 = np.dtype([("quint8", np.uint8, 1)])
/Users/ally/open_spiel-master/venv/lib/python3.6/site-packages/tensorflow/python/framework/dtypes.py:518: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_qint16 = np.dtype([("qint16", np.int16, 1)])
/Users/ally/open_spiel-master/venv/lib/python3.6/site-packages/tensorflow/python/framework/dtypes.py:519: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_quint16 = np.dtype([("quint16", np.uint16, 1)])
/Users/ally/open_spiel-master/venv/lib/python3.6/site-packages/tensorflow/python/framework/dtypes.py:520: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_qint32 = np.dtype([("qint32", np.int32, 1)])
/Users/ally/open_spiel-master/venv/lib/python3.6/site-packages/tensorflow/python/framework/dtypes.py:525: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
np_resource = np.dtype([("resource", np.ubyte, 1)])
/Users/ally/open_spiel-master/venv/lib/python3.6/site-packages/tensorboard/compat/tensorflow_stub/dtypes.py:541: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_qint8 = np.dtype([("qint8", np.int8, 1)])
/Users/ally/open_spiel-master/venv/lib/python3.6/site-packages/tensorboard/compat/tensorflow_stub/dtypes.py:542: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_quint8 = np.dtype([("quint8", np.uint8, 1)])
/Users/ally/open_spiel-master/venv/lib/python3.6/site-packages/tensorboard/compat/tensorflow_stub/dtypes.py:543: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_qint16 = np.dtype([("qint16", np.int16, 1)])
/Users/ally/open_spiel-master/venv/lib/python3.6/site-packages/tensorboard/compat/tensorflow_stub/dtypes.py:544: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_quint16 = np.dtype([("quint16", np.uint16, 1)])
/Users/ally/open_spiel-master/venv/lib/python3.6/site-packages/tensorboard/compat/tensorflow_stub/dtypes.py:545: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_qint32 = np.dtype([("qint32", np.int32, 1)])
/Users/ally/open_spiel-master/venv/lib/python3.6/site-packages/tensorboard/compat/tensorflow_stub/dtypes.py:550: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
np_resource = np.dtype([("resource", np.ubyte, 1)])
Traceback (most recent call last):
File "/Users/ally/open_spiel-master/open_spiel/python/../python/algorithms/exploitability_descent_test.py", line 24, in
from open_spiel.python.algorithms import exploitability_descent
File "/Users/ally/open_spiel-master/open_spiel/python/algorithms/exploitability_descent.py", line 44, in
from open_spiel.python import policy
File "/Users/ally/open_spiel-master/open_spiel/python/policy.py", line 40, in
import pyspiel
ImportError: dlopen(/Users/ally/open_spiel-master/build/python/pyspiel.so, 2): Symbol not found: _PyThread_tss_alloc
Referenced from: /Users/ally/open_spiel-master/build/python/pyspiel.so
Expected in: flat namespace
in /Users/ally/open_spiel-master/build/python/pyspiel.so

  Start 82: python_dynamics_test

25/94 Test #55: python_dqn_test .............................***Failed 8.11 sec
/Users/ally/open_spiel-master/venv/lib/python3.6/site-packages/tensorflow/python/framework/dtypes.py:516: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_qint8 = np.dtype([("qint8", np.int8, 1)])
/Users/ally/open_spiel-master/venv/lib/python3.6/site-packages/tensorflow/python/framework/dtypes.py:517: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_quint8 = np.dtype([("quint8", np.uint8, 1)])
/Users/ally/open_spiel-master/venv/lib/python3.6/site-packages/tensorflow/python/framework/dtypes.py:518: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_qint16 = np.dtype([("qint16", np.int16, 1)])
/Users/ally/open_spiel-master/venv/lib/python3.6/site-packages/tensorflow/python/framework/dtypes.py:519: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_quint16 = np.dtype([("quint16", np.uint16, 1)])
/Users/ally/open_spiel-master/venv/lib/python3.6/site-packages/tensorflow/python/framework/dtypes.py:520: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_qint32 = np.dtype([("qint32", np.int32, 1)])
/Users/ally/open_spiel-master/venv/lib/python3.6/site-packages/tensorflow/python/framework/dtypes.py:525: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
np_resource = np.dtype([("resource", np.ubyte, 1)])
/Users/ally/open_spiel-master/venv/lib/python3.6/site-packages/tensorboard/compat/tensorflow_stub/dtypes.py:541: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_qint8 = np.dtype([("qint8", np.int8, 1)])
/Users/ally/open_spiel-master/venv/lib/python3.6/site-packages/tensorboard/compat/tensorflow_stub/dtypes.py:542: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_quint8 = np.dtype([("quint8", np.uint8, 1)])
/Users/ally/open_spiel-master/venv/lib/python3.6/site-packages/tensorboard/compat/tensorflow_stub/dtypes.py:543: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_qint16 = np.dtype([("qint16", np.int16, 1)])
/Users/ally/open_spiel-master/venv/lib/python3.6/site-packages/tensorboard/compat/tensorflow_stub/dtypes.py:544: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_quint16 = np.dtype([("quint16", np.uint16, 1)])
/Users/ally/open_spiel-master/venv/lib/python3.6/site-packages/tensorboard/compat/tensorflow_stub/dtypes.py:545: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_qint32 = np.dtype([("qint32", np.int32, 1)])
/Users/ally/open_spiel-master/venv/lib/python3.6/site-packages/tensorboard/compat/tensorflow_stub/dtypes.py:550: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
np_resource = np.dtype([("resource", np.ubyte, 1)])
Traceback (most recent call last):
File "/Users/ally/open_spiel-master/open_spiel/python/../python/algorithms/dqn_test.py", line 23, in
from open_spiel.python import rl_environment
File "/Users/ally/open_spiel-master/open_spiel/python/rl_environment.py", line 57, in
import pyspiel
ImportError: dlopen(/Users/ally/open_spiel-master/build/python/pyspiel.so, 2): Symbol not found: _PyThread_tss_alloc
Referenced from: /Users/ally/open_spiel-master/build/python/pyspiel.so
Expected in: flat namespace
in /Users/ally/open_spiel-master/build/python/pyspiel.so

  Start 83: python_heuristic_payoff_table_test

26/94 Test #54: python_deep_cfr_test ........................***Failed 8.19 sec
/Users/ally/open_spiel-master/venv/lib/python3.6/site-packages/tensorflow/python/framework/dtypes.py:516: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_qint8 = np.dtype([("qint8", np.int8, 1)])
/Users/ally/open_spiel-master/venv/lib/python3.6/site-packages/tensorflow/python/framework/dtypes.py:517: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_quint8 = np.dtype([("quint8", np.uint8, 1)])
/Users/ally/open_spiel-master/venv/lib/python3.6/site-packages/tensorflow/python/framework/dtypes.py:518: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_qint16 = np.dtype([("qint16", np.int16, 1)])
/Users/ally/open_spiel-master/venv/lib/python3.6/site-packages/tensorflow/python/framework/dtypes.py:519: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_quint16 = np.dtype([("quint16", np.uint16, 1)])
/Users/ally/open_spiel-master/venv/lib/python3.6/site-packages/tensorflow/python/framework/dtypes.py:520: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_qint32 = np.dtype([("qint32", np.int32, 1)])
/Users/ally/open_spiel-master/venv/lib/python3.6/site-packages/tensorflow/python/framework/dtypes.py:525: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
np_resource = np.dtype([("resource", np.ubyte, 1)])
/Users/ally/open_spiel-master/venv/lib/python3.6/site-packages/tensorboard/compat/tensorflow_stub/dtypes.py:541: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_qint8 = np.dtype([("qint8", np.int8, 1)])
/Users/ally/open_spiel-master/venv/lib/python3.6/site-packages/tensorboard/compat/tensorflow_stub/dtypes.py:542: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_quint8 = np.dtype([("quint8", np.uint8, 1)])
/Users/ally/open_spiel-master/venv/lib/python3.6/site-packages/tensorboard/compat/tensorflow_stub/dtypes.py:543: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_qint16 = np.dtype([("qint16", np.int16, 1)])
/Users/ally/open_spiel-master/venv/lib/python3.6/site-packages/tensorboard/compat/tensorflow_stub/dtypes.py:544: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_quint16 = np.dtype([("quint16", np.uint16, 1)])
/Users/ally/open_spiel-master/venv/lib/python3.6/site-packages/tensorboard/compat/tensorflow_stub/dtypes.py:545: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_qint32 = np.dtype([("qint32", np.int32, 1)])
/Users/ally/open_spiel-master/venv/lib/python3.6/site-packages/tensorboard/compat/tensorflow_stub/dtypes.py:550: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
np_resource = np.dtype([("resource", np.ubyte, 1)])
Traceback (most recent call last):
File "/Users/ally/open_spiel-master/open_spiel/python/../python/algorithms/deep_cfr_test.py", line 24, in
from open_spiel.python import policy
File "/Users/ally/open_spiel-master/open_spiel/python/policy.py", line 40, in
import pyspiel
ImportError: dlopen(/Users/ally/open_spiel-master/build/python/pyspiel.so, 2): Symbol not found: _PyThread_tss_alloc
Referenced from: /Users/ally/open_spiel-master/build/python/pyspiel.so
Expected in: flat namespace
in /Users/ally/open_spiel-master/build/python/pyspiel.so

  Start 84: python_utils_test

27/94 Test #70: python_policy_gradient_test .................***Failed 6.63 sec
/Users/ally/open_spiel-master/venv/lib/python3.6/site-packages/tensorflow/python/framework/dtypes.py:516: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_qint8 = np.dtype([("qint8", np.int8, 1)])
/Users/ally/open_spiel-master/venv/lib/python3.6/site-packages/tensorflow/python/framework/dtypes.py:517: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_quint8 = np.dtype([("quint8", np.uint8, 1)])
/Users/ally/open_spiel-master/venv/lib/python3.6/site-packages/tensorflow/python/framework/dtypes.py:518: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_qint16 = np.dtype([("qint16", np.int16, 1)])
/Users/ally/open_spiel-master/venv/lib/python3.6/site-packages/tensorflow/python/framework/dtypes.py:519: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_quint16 = np.dtype([("quint16", np.uint16, 1)])
/Users/ally/open_spiel-master/venv/lib/python3.6/site-packages/tensorflow/python/framework/dtypes.py:520: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_qint32 = np.dtype([("qint32", np.int32, 1)])
/Users/ally/open_spiel-master/venv/lib/python3.6/site-packages/tensorflow/python/framework/dtypes.py:525: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
np_resource = np.dtype([("resource", np.ubyte, 1)])
/Users/ally/open_spiel-master/venv/lib/python3.6/site-packages/tensorboard/compat/tensorflow_stub/dtypes.py:541: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_qint8 = np.dtype([("qint8", np.int8, 1)])
/Users/ally/open_spiel-master/venv/lib/python3.6/site-packages/tensorboard/compat/tensorflow_stub/dtypes.py:542: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_quint8 = np.dtype([("quint8", np.uint8, 1)])
/Users/ally/open_spiel-master/venv/lib/python3.6/site-packages/tensorboard/compat/tensorflow_stub/dtypes.py:543: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_qint16 = np.dtype([("qint16", np.int16, 1)])
/Users/ally/open_spiel-master/venv/lib/python3.6/site-packages/tensorboard/compat/tensorflow_stub/dtypes.py:544: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_quint16 = np.dtype([("quint16", np.uint16, 1)])
/Users/ally/open_spiel-master/venv/lib/python3.6/site-packages/tensorboard/compat/tensorflow_stub/dtypes.py:545: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_qint32 = np.dtype([("qint32", np.int32, 1)])
/Users/ally/open_spiel-master/venv/lib/python3.6/site-packages/tensorboard/compat/tensorflow_stub/dtypes.py:550: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
np_resource = np.dtype([("resource", np.ubyte, 1)])
Traceback (most recent call last):
File "/Users/ally/open_spiel-master/open_spiel/python/../python/algorithms/policy_gradient_test.py", line 26, in
from open_spiel.python import rl_environment
File "/Users/ally/open_spiel-master/open_spiel/python/rl_environment.py", line 57, in
import pyspiel
ImportError: dlopen(/Users/ally/open_spiel-master/build/python/pyspiel.so, 2): Symbol not found: _PyThread_tss_alloc
Referenced from: /Users/ally/open_spiel-master/build/python/pyspiel.so
Expected in: flat namespace
in /Users/ally/open_spiel-master/build/python/pyspiel.so

  Start 85: python_visualization_test

28/94 Test #82: python_dynamics_test ........................***Failed 1.14 sec
Traceback (most recent call last):
File "/Users/ally/open_spiel-master/open_spiel/python/../python/egt/dynamics_test.py", line 29, in
import pyspiel
ImportError: dlopen(/Users/ally/open_spiel-master/build/python/pyspiel.so, 2): Symbol not found: _PyThread_tss_alloc
Referenced from: /Users/ally/open_spiel-master/build/python/pyspiel.so
Expected in: flat namespace
in /Users/ally/open_spiel-master/build/python/pyspiel.so

  Start 86: python_catch_test

29/94 Test #80: python_alpharank_test .......................***Failed 3.55 sec

……

from open_spiel.

alexminnaar avatar alexminnaar commented on May 23, 2024

@allychina I'm not sure about the tests that failed but assuming that you were able to build successfully, the ModuleNotFoundError: No module named 'pyspiel' might be related to Step 4 of the instructions. i.e.

# For the python modules in open_spiel.
export PYTHONPATH=$PYTHONPATH:/<path_to_open_spiel>
# For the Python bindings of Pyspiel
export PYTHONPATH=$PYTHONPATH:/<path_to_open_spiel>/build/python

It won't be able to find pyspiel unless you do these exports. But for the second one, your build directory might actually be build_python_3 rather than build so be careful with that.

from open_spiel.

lanctot avatar lanctot commented on May 23, 2024

@alexminnaar: we have changed the build dir now to just build (wasn't it you who submitted that PR?)

from open_spiel.

allychina avatar allychina commented on May 23, 2024

@allychina I'm not sure about the tests that failed but assuming that you were able to build successfully, the ModuleNotFoundError: No module named 'pyspiel' might be related to Step 4 of the instructions. i.e.

# For the python modules in open_spiel.
export PYTHONPATH=$PYTHONPATH:/<path_to_open_spiel>
# For the Python bindings of Pyspiel
export PYTHONPATH=$PYTHONPATH:/<path_to_open_spiel>/build/python

It won't be able to find pyspiel unless you do these exports. But for the second one, your build directory might actually be build_python_3 rather than build so be careful with that.

i have done step4, and when type echo $pythonpath,show this:

(venv) ZhongHuiMacBook:open_spiel-master ally$ echo $PYTHONPATH
:/open_spiel-master/open_spiel:/open_spiel-master/open_spiel/build/python

i assume it works well, right?
and still problem unsolved

from open_spiel.

alexminnaar avatar alexminnaar commented on May 23, 2024

@allychina is that the full path to open_spiel or a relative path?

from open_spiel.

lanctot avatar lanctot commented on May 23, 2024

Hmm yeah that PYTHONPATH does not seem to be right. From the output above it seems to be missing /Users/ally. Good call @alexminnaar.

But I don't think that is the problem because the script exports PYTHONPATH manually, see here: https://github.com/deepmind/open_spiel/blob/e39f9c2950f990c8c974e4bab4968c8ed6ef0638/open_spiel/scripts/build_and_run_tests.sh#L52

I have seen these errors that look like the ones in your output before, though, in the NeuRD example and tests that we needed to disable (see: #18)

@allychina: can you tell us what version of Tensorflow you have installed?

from open_spiel.

allychina avatar allychina commented on May 23, 2024

tensorflow 1.14.0
tensorflow-estimator 1.14.0
tensorflow-probability 0.7.0

i have change the full path. still have the error, part of the error message:
Start 44: tiny_bridge_test
41/94 Test #93: python_pyspiel_test .........................***Failed 0.88 sec
Traceback (most recent call last):
File "/Users/ally/open_spiel-master/open_spiel/python/../python/tests/pyspiel_test.py", line 24, in
from open_spiel.python import policy
File "/Users/ally/open_spiel-master/open_spiel/python/policy.py", line 40, in
import pyspiel
ImportError: dlopen(/Users/ally/open_spiel-master/build/python/pyspiel.so, 2): Symbol not found: _PyThread_tss_alloc
Referenced from: /Users/ally/open_spiel-master/build/python/pyspiel.so
Expected in: flat namespace
in /Users/ally/open_spiel-master/build/python/pyspiel.so

  Start 48: spiel_test

42/94 Test #94: python_rl_environment_test ..................***Failed 0.84 sec
Traceback (most recent call last):
File "/Users/ally/open_spiel-master/open_spiel/python/../python/tests/rl_environment_test.py", line 23, in
from open_spiel.python import rl_environment
File "/Users/ally/open_spiel-master/open_spiel/python/rl_environment.py", line 57, in
import pyspiel
ImportError: dlopen(/Users/ally/open_spiel-master/build/python/pyspiel.so, 2): Symbol not found: _PyThread_tss_alloc
Referenced from: /Users/ally/open_spiel-master/build/python/pyspiel.so
Expected in: flat namespace
in /Users/ally/open_spiel-master/build/python/pyspiel.so

from open_spiel.

lanctot avatar lanctot commented on May 23, 2024

We are currently requiring a specific range of TF versions. You might be able to fix it by upgrading (or downgrading) TF with the following commd:

pip3 install -r requirements.txt --upgrade

Note the --upgrade which might not have been present in your original commands.

from open_spiel.

lanctot avatar lanctot commented on May 23, 2024

Hmm ok that's not it. Seems like pyspiel did not get built properly. Did you build with clang or g++? Your original message seemed to be using clang and maybe now it's reusing a badly built pyspiel.so? I would remove the entire build dir and start again.

from open_spiel.

allychina avatar allychina commented on May 23, 2024

i have upgrade, not work out... i think it did not change my version of tensorflow with this command..

(venv) ZhongHuiMacBook:open_spiel-master ally$ pip3 install -r requirements.txt --upgrade

Requirement already up-to-date: absl-py==0.7.1 in ./venv/lib/python3.6/site-packages (from -r requirements.txt (line 2)) (0.7.1)
Requirement already up-to-date: tensorflow<1.15.0,>=1.14.0 in ./venv/lib/python3.6/site-packages (from -r requirements.txt (line 3)) (1.14.0)
Requirement already up-to-date: dm-sonnet==1.32 in ./venv/lib/python3.6/site-packages (from -r requirements.txt (line 4)) (1.32)
Requirement already up-to-date: IPython==5.8.0 in ./venv/lib/python3.6/site-packages (from -r requirements.txt (line 5)) (5.8.0)
Requirement already up-to-date: tensorflow-probability<0.8.0,>=0.7.0 in ./venv/lib/python3.6/site-packages (from -r requirements.txt (line 6)) (0.7.0)
Requirement already up-to-date: cvxopt==1.2.3 in ./venv/lib/python3.6/site-packages (from -r requirements.txt (line 7)) (1.2.3)
Requirement already up-to-date: networkx==2.2 in ./venv/lib/python3.6/site-packages (from -r requirements.txt (line 8)) (2.2)
Requirement already up-to-date: mock==3.0.5 in ./venv/lib/python3.6/site-packages (from -r requirements.txt (line 9)) (3.0.5)
Requirement already up-to-date: matplotlib==3.1.1 in ./venv/lib/python3.6/site-packages (from -r requirements.txt (line 10)) (3.1.1)
Requirement already up-to-date: scipy==1.1.0 in ./venv/lib/python3.6/site-packages (from -r requirements.txt (line 11)) (1.1.0)
Requirement already up-to-date: attrs==19.1.0 in ./venv/lib/python3.6/site-packages (from -r requirements.txt (line 12)) (19.1.0)
Requirement already satisfied, skipping upgrade: six in ./venv/lib/python3.6/site-packages (from absl-py==0.7.1->-r requirements.txt (line 2)) (1.12.0)
Requirement already satisfied, skipping upgrade: termcolor>=1.1.0 in ./venv/lib/python3.6/site-packages (from tensorflow<1.15.0,>=1.14.0->-r requirements.txt (line 3)) (1.1.0)
Requirement already satisfied, skipping upgrade: astor>=0.6.0 in ./venv/lib/python3.6/site-packages (from tensorflow<1.15.0,>=1.14.0->-r requirements.txt (line 3)) (0.8.0)
Requirement already satisfied, skipping upgrade: numpy<2.0,>=1.14.5 in ./venv/lib/python3.6/site-packages (from tensorflow<1.15.0,>=1.14.0->-r requirements.txt (line 3)) (1.17.2)
Requirement already satisfied, skipping upgrade: tensorboard<1.15.0,>=1.14.0 in ./venv/lib/python3.6/site-packages (from tensorflow<1.15.0,>=1.14.0->-r requirements.txt (line 3)) (1.14.0)
Requirement already satisfied, skipping upgrade: wrapt>=1.11.1 in ./venv/lib/python3.6/site-packages (from tensorflow<1.15.0,>=1.14.0->-r requirements.txt (line 3)) (1.11.2)
Requirement already satisfied, skipping upgrade: google-pasta>=0.1.6 in ./venv/lib/python3.6/site-packages (from tensorflow<1.15.0,>=1.14.0->-r requirements.txt (line 3)) (0.1.7)
Requirement already satisfied, skipping upgrade: keras-preprocessing>=1.0.5 in ./venv/lib/python3.6/site-packages (from tensorflow<1.15.0,>=1.14.0->-r requirements.txt (line 3)) (1.1.0)
Requirement already satisfied, skipping upgrade: grpcio>=1.8.6 in ./venv/lib/python3.6/site-packages (from tensorflow<1.15.0,>=1.14.0->-r requirements.txt (line 3)) (1.23.0)
Requirement already satisfied, skipping upgrade: wheel>=0.26 in ./venv/lib/python3.6/site-packages (from tensorflow<1.15.0,>=1.14.0->-r requirements.txt (line 3)) (0.33.6)
Requirement already satisfied, skipping upgrade: gast>=0.2.0 in ./venv/lib/python3.6/site-packages (from tensorflow<1.15.0,>=1.14.0->-r requirements.txt (line 3)) (0.3.2)
Requirement already satisfied, skipping upgrade: keras-applications>=1.0.6 in ./venv/lib/python3.6/site-packages (from tensorflow<1.15.0,>=1.14.0->-r requirements.txt (line 3)) (1.0.8)
Requirement already satisfied, skipping upgrade: protobuf>=3.6.1 in ./venv/lib/python3.6/site-packages (from tensorflow<1.15.0,>=1.14.0->-r requirements.txt (line 3)) (3.9.1)
Requirement already satisfied, skipping upgrade: tensorflow-estimator<1.15.0rc0,>=1.14.0rc0 in ./venv/lib/python3.6/site-packages (from tensorflow<1.15.0,>=1.14.0->-r requirements.txt (line 3)) (1.14.0)
Requirement already satisfied, skipping upgrade: semantic-version in ./venv/lib/python3.6/site-packages (from dm-sonnet==1.32->-r requirements.txt (line 4)) (2.8.2)
Requirement already satisfied, skipping upgrade: contextlib2 in ./venv/lib/python3.6/site-packages (from dm-sonnet==1.32->-r requirements.txt (line 4)) (0.5.5)
Requirement already satisfied, skipping upgrade: pexpect; sys_platform != "win32" in ./venv/lib/python3.6/site-packages (from IPython==5.8.0->-r requirements.txt (line 5)) (4.7.0)
Requirement already satisfied, skipping upgrade: pygments in ./venv/lib/python3.6/site-packages (from IPython==5.8.0->-r requirements.txt (line 5)) (2.4.2)
Requirement already satisfied, skipping upgrade: pickleshare in ./venv/lib/python3.6/site-packages (from IPython==5.8.0->-r requirements.txt (line 5)) (0.7.5)
Requirement already satisfied, skipping upgrade: appnope; sys_platform == "darwin" in ./venv/lib/python3.6/site-packages (from IPython==5.8.0->-r requirements.txt (line 5)) (0.1.0)
Requirement already satisfied, skipping upgrade: traitlets>=4.2 in ./venv/lib/python3.6/site-packages (from IPython==5.8.0->-r requirements.txt (line 5)) (4.3.2)
Requirement already satisfied, skipping upgrade: prompt-toolkit<2.0.0,>=1.0.4 in ./venv/lib/python3.6/site-packages (from IPython==5.8.0->-r requirements.txt (line 5)) (1.0.16)
Requirement already satisfied, skipping upgrade: setuptools>=18.5 in ./venv/lib/python3.6/site-packages (from IPython==5.8.0->-r requirements.txt (line 5)) (41.2.0)
Requirement already satisfied, skipping upgrade: simplegeneric>0.8 in ./venv/lib/python3.6/site-packages (from IPython==5.8.0->-r requirements.txt (line 5)) (0.8.1)
Requirement already satisfied, skipping upgrade: decorator in ./venv/lib/python3.6/site-packages (from IPython==5.8.0->-r requirements.txt (line 5)) (4.4.0)
Requirement already satisfied, skipping upgrade: cloudpickle>=0.6.1 in ./venv/lib/python3.6/site-packages (from tensorflow-probability<0.8.0,>=0.7.0->-r requirements.txt (line 6)) (1.2.2)
Requirement already satisfied, skipping upgrade: cycler>=0.10 in ./venv/lib/python3.6/site-packages (from matplotlib==3.1.1->-r requirements.txt (line 10)) (0.10.0)
Requirement already satisfied, skipping upgrade: python-dateutil>=2.1 in ./venv/lib/python3.6/site-packages (from matplotlib==3.1.1->-r requirements.txt (line 10)) (2.8.0)
Requirement already satisfied, skipping upgrade: kiwisolver>=1.0.1 in ./venv/lib/python3.6/site-packages (from matplotlib==3.1.1->-r requirements.txt (line 10)) (1.1.0)
Requirement already satisfied, skipping upgrade: pyparsing!=2.0.4,!=2.1.2,!=2.1.6,>=2.0.1 in ./venv/lib/python3.6/site-packages (from matplotlib==3.1.1->-r requirements.txt (line 10)) (2.4.2)
Requirement already satisfied, skipping upgrade: werkzeug>=0.11.15 in ./venv/lib/python3.6/site-packages (from tensorboard<1.15.0,>=1.14.0->tensorflow<1.15.0,>=1.14.0->-r requirements.txt (line 3)) (0.16.0)
Requirement already satisfied, skipping upgrade: markdown>=2.6.8 in ./venv/lib/python3.6/site-packages (from tensorboard<1.15.0,>=1.14.0->tensorflow<1.15.0,>=1.14.0->-r requirements.txt (line 3)) (3.1.1)
Requirement already satisfied, skipping upgrade: h5py in ./venv/lib/python3.6/site-packages (from keras-applications>=1.0.6->tensorflow<1.15.0,>=1.14.0->-r requirements.txt (line 3)) (2.10.0)
Requirement already satisfied, skipping upgrade: ptyprocess>=0.5 in ./venv/lib/python3.6/site-packages (from pexpect; sys_platform != "win32"->IPython==5.8.0->-r requirements.txt (line 5)) (0.6.0)
Requirement already satisfied, skipping upgrade: ipython-genutils in ./venv/lib/python3.6/site-packages (from traitlets>=4.2->IPython==5.8.0->-r requirements.txt (line 5)) (0.2.0)
Requirement already satisfied, skipping upgrade: wcwidth in ./venv/lib/python3.6/site-packages (from prompt-toolkit<2.0.0,>=1.0.4->IPython==5.8.0->-r requirements.txt (line 5)) (0.1.7)

from open_spiel.

lanctot avatar lanctot commented on May 23, 2024

If it still fails can you try two things:

  1. Remove this line:

https://github.com/deepmind/open_spiel/blob/e39f9c2950f990c8c974e4bab4968c8ed6ef0638/open_spiel/CMakeLists.txt#L13

That line was required for building pyspiel on Macs but I wonder if it is more subtle than that (what is your version of MacOS?)

  1. If still doesnt work, then try moving that line outside the if (APPLE)-- maybe the conditional is failing.

from open_spiel.

lanctot avatar lanctot commented on May 23, 2024

Can you try removing the build dir entirely and rerunning the script?

If that doesn't work can you try the two suggestions in my last response?

from open_spiel.

allychina avatar allychina commented on May 23, 2024

Hmm ok that's not it. Seems like pyspiel did not get built properly. Did you build with clang or g++? Your original message seemed to be using clang and maybe now it's reusing a badly built pyspiel.so? I would remove the entire build dir and start again.

i am a beginner for computer science. and don't really know which of clang and g++ is used?

from open_spiel.

allychina avatar allychina commented on May 23, 2024

i rerun the scripts after remove the build dir, when scan the independencies, it show the warning:
ld: warning: text-based stub file /System/Library/Frameworks//CoreFoundation.framework/CoreFoundation.tbd and library file /System/Library/Frameworks//CoreFoundation.framework/CoreFoundation are out of sync. Falling back to library file for linking.
[ 75%] Linking CXX executable evaluate_bots_test
[ 75%] Built target cfr_test
Scanning dependencies of target external_sampling_mccfr_test
[ 75%] Building CXX object algorithms/CMakeFiles/external_sampling_mccfr_test.dir/external_sampling_mccfr_test.cc.o
ld: warning: text-based stub file /System/Library/Frameworks//CoreFoundation.framework/CoreFoundation.tbd and library file /System/Library/Frameworks//CoreFoundation.framework/CoreFoundation are out of sync. Falling back to library file for linking.
[ 75%] Built target evaluate_bots_test

is it matter?

from open_spiel.

allychina avatar allychina commented on May 23, 2024

Can you try removing the build dir entirely and rerunning the script?

If that doesn't work can you try the two suggestions in my last response?

hi, i have tried the modifed scripts, following your instruction.

set (CMAKE_CXX_STANDARD 11)
#if(APPLE)
#set (CMAKE_CXX_FLAGS "-Werror -undefined dynamic_lookup")
#else()
set (CMAKE_CXX_FLAGS "-Werror")
#endif()

and it not work...

from open_spiel.

allychina avatar allychina commented on May 23, 2024

my mac is 10.13.6
and some information:

  • CXX=g++
  • NPROC=nproc
  • [[ darwin17 == \d\a\r\w\i\n* ]]
  • NPROC='sysctl -n hw.physicalcpu'
  • CXX=/usr/local/bin/g++-7
    ++ sysctl -n hw.physicalcpu
  • MAKE_NUM_PROCS=2
  • let 'TEST_NUM_PROCS=4*2'
    ++ python3 -c 'import sys; print(sys.version.split(" ")[0])'
  • PYVERSION=3.6.5
  • BUILD_DIR=build
  • mkdir -p build
  • cd build
  • echo 'Building and testing in /Users/ally/open_spiel-master/build using '''python''' (version 3.6.5).'
    Building and testing in /Users/ally/open_spiel-master/build using 'python' (version 3.6.5).
  • cmake -DPython_TARGET_VERSION=3.6.5 -DCMAKE_CXX_COMPILER=/usr/local/bin/g++-7 ../open_spiel
    -- The C compiler identification is AppleClang 10.0.0.10001044
    -- The CXX compiler identification is GNU 7.3.0
    -- Check for working C compiler: /Library/Developer/CommandLineTools/usr/bin/cc
    -- Check for working C compiler: /Library/Developer/CommandLineTools/usr/bin/cc -- works
    -- Detecting C compiler ABI info
    -- Detecting C compiler ABI info - done
    -- Detecting C compile features
    -- Detecting C compile features - done
    -- Checking whether CXX compiler has -isysroot
    -- Checking whether CXX compiler has -isysroot - yes
    -- Checking whether CXX compiler supports OSX deployment target flag
    -- Checking whether CXX compiler supports OSX deployment target flag - yes
    -- Check for working CXX compiler: /usr/local/bin/g++-7
    -- Check for working CXX compiler: /usr/local/bin/g++-7 -- works
    -- Detecting CXX compiler ABI info
    -- Detecting CXX compiler ABI info - done
    -- Detecting CXX compile features
    -- Detecting CXX compile features - done
    -- Looking for pthread.h
    -- Looking for pthread.h - found
    -- Looking for pthread_create
    -- Looking for pthread_create - found
    -- Found Threads: TRUE
    -- Found Python3: /usr/local/opt/python/Frameworks/Python.framework/Versions/3.7/lib/libpython3.7m.dylib (found version "3.7.1") found components: Development
    -- Configuring done
    -- Generating done
    -- Build files have been written to: /Users/ally/open_spiel-master/build

from open_spiel.

allychina avatar allychina commented on May 23, 2024

i think the original scripts is proper

from open_spiel.

lanctot avatar lanctot commented on May 23, 2024

i think the original scripts is proper

Ok, does that mean it is working? Have all the tests passed now? If not, what's the error you get when using the original CMakeFiles.txt?

From the info you posted, it seems to be using g++7 which is correct.

Regarding the link errors you posted, I don't know if it's a big problem, but I found some information about it here: https://stackoverflow.com/questions/51314888/ld-warning-text-based-stub-file-are-out-of-sync-falling-back-to-library-file

from open_spiel.

ouya99 avatar ouya99 commented on May 23, 2024

got everything built following your comments... but now I am missing python symbols:

Undefined symbols for architecture x86_64:
"_PyBaseObject_Type", referenced from:
pybind11::detail::make_object_base_type(_typeobject*) in pyspiel.cc.o

How to add these correctly to the build files? or maybe fix it for the system installation.?. (not sure).

python version 3.7 , macOs Sierra

Thanks

from open_spiel.

githubgit avatar githubgit commented on May 23, 2024

hello @lanctot I got some errors like @allychina and following your proposals was able to build only to 60%. build log attached. I appreciate if you could help me, please
build_log.txt

from open_spiel.

lanctot avatar lanctot commented on May 23, 2024

@githubgit those look like basic C++ compilation problems. I highly suspect that you're using a different compiler. I would upgrade XCode and then rerun ./install.sh to get g++ from brew.

from open_spiel.

githubgit avatar githubgit commented on May 23, 2024

@lanctot thanks for quick answer.
Hmm It seems like latest Xcode installed here: Version 11.0 (11A420a). I'm on macOS Mojave 10.14.6 (18G95)
$ g++ --version
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/c++/4.2.1
Apple clang version 11.0.0 (clang-1100.0.33.8)
Target: x86_64-apple-darwin18.7.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

from open_spiel.

lanctot avatar lanctot commented on May 23, 2024

Can you confirm that you have successfully run the brew commands in install.sh?

from open_spiel.

githubgit avatar githubgit commented on May 23, 2024

@lanctot Yes, install.sh was ok. Running it now gives the following:
MacBookPro:open_spiel vlad$ ./install.sh

  • git --version
  • GIT_IS_AVAILABLE=0
  • '[' 0 -ne 0 ']'
  • [[ -d ./pybind11 ]]
  • [[ -d open_spiel/games/bridge/double_dummy_solver ]]
  • [[ -d open_spiel/abseil-cpp ]]
  • [[ darwin18 == \l\i\n\u\x-\g\n\u ]]
  • [[ darwin18 == \d\a\r\w\i\n* ]]
    ++ type python3
  • [[ -x python3 is /usr/local/bin/python3 ]]
  • brew install python3
    Warning: python 3.7.4_1 is already installed and up-to-date
    To reinstall 3.7.4_1, run brew reinstall python
    ++ type g++-7
  • [[ -x g++-7 is /usr/local/bin/g++-7 ]]
  • brew install gcc@7
    Warning: gcc@7 7.4.0_2 is already installed and up-to-date
    To reinstall 7.4.0_2, run brew reinstall gcc@7
  • curl https://bootstrap.pypa.io/get-pip.py -o get-pip.py
    % Total % Received % Xferd Average Speed Time Time Time Current
    Dload Upload Total Spent Left Speed
    100 1733k 100 1733k 0 0 1574k 0 0:00:01 0:00:01 --:--:-- 1574k
  • python3 get-pip.py
    Collecting pip
    Using cached https://files.pythonhosted.org/packages/30/db/9e38760b32e3e7f40cce46dd5fb107b8c73840df38f0046d8e6514e675a1/pip-19.2.3-py2.py3-none-any.whl
    Installing collected packages: pip
    Found existing installation: pip 19.2.3
    Uninstalling pip-19.2.3:
    Successfully uninstalled pip-19.2.3
    Successfully installed pip-19.2.3
  • pip3 install virtualenv
    Requirement already satisfied: virtualenv in /usr/local/lib/python3.7/site-packages (16.7.5)

from open_spiel.

lanctot avatar lanctot commented on May 23, 2024

Hmm, can you try manually rebuilding and expliclty setting g++ as the compiler?

pip3 install --upgrade -r requirements.txt
rm -rf build
mkdir build
cd build
CXX=g++ cmake -DPython_TARGET_VERSION=3.7 -DCMAKE_CXX_COMPILER=g++ ../open_spiel
make -j12
ctest -j12

from open_spiel.

githubgit avatar githubgit commented on May 23, 2024

@lanctot Tried - the same here
logs attached
build_log.txt

from open_spiel.

ai-gamer avatar ai-gamer commented on May 23, 2024

When I try to compile the c++ repository in Clion, I also get error like:
clang: : : error: argument unused during compilation: '-undefined dynamic_lookup' [-Werror,-Wunused-command-line-argument]

It turns out that I am not using g++ as compiler. After I fix it, everything works. @githubgit

from open_spiel.

jblespiau avatar jblespiau commented on May 23, 2024

This specific bug seems to be fixed, as on MacOS, one indeed needs to use g++ as the compiler, and the rest should follow.

If you have a good way to configure CMake or change the install line to use g++ on MacOS, feel free to contribute a PR for documentation or the build_and_run.sh script (as we do not use MacOS at all).

Also, if one wants to add MacOS support on TravisCI, this would be a good way to check it never break! Without activity, I may be closing this.

from open_spiel.

githubgit avatar githubgit commented on May 23, 2024

Found latest installed gcc compiler is gcc 9.2
So in my case correct command before make (in macOS Mojave) was
CXX=g++-9 cmake -DPython_TARGET_VERSION=3.6 -DCMAKE_CXX_COMPILER=${CXX} ../open_spiel
So for me build issue is solved, Thanks

from open_spiel.

ouya99 avatar ouya99 commented on May 23, 2024

@githubgit i can compile it but linking is now a problem

[100%] Linking CXX shared module pyspiel.so Undefined symbols for architecture x86_64: "_PyBaseObject_Type", referenced from: pybind11::detail::make_object_base_type(_typeobject*) in pyspiel.cc.o

How did you set your python environment to enable linking?

from open_spiel.

lanctot avatar lanctot commented on May 23, 2024

Hello everyone, I just tried compiling on MacOS (Mojave 10.14.6) and ran into all the same problems you've shown here (even though I was using g++).

I managed to get it to work by changing the top of CMakeLists.txt to the following:

if(APPLE)
  # set (CMAKE_CXX_FLAGS "-Werror -undefined dynamic_lookup")
  set (CMAKE_CXX_FLAGS "-w -undefined dynamic_lookup")
else()
  set (CMAKE_CXX_FLAGS "-Werror")
endif()

To try this you need to completely start your build over and rerun CMake:

rm -rf build
cd build
CXX=g++ cmake -DPython_TARGET_VERSION=3.7 -DCMAKE_CXX_COMPILER=g++ ../open_spiel
make -j12
ctest -j12

@ouya99, @allychina: this should fix it for you. Please try it at let us know. Thanks!

from open_spiel.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.