Git Product home page Git Product logo

Comments (5)

lanctot avatar lanctot commented on June 19, 2024

@elkhrt wdyt?

from open_spiel.

elkhrt avatar elkhrt commented on June 19, 2024

This seems reasonable to me. I wouldn't bother with absolute_order - just implement whichever works better.

from open_spiel.

ZiggerZZ avatar ZiggerZZ commented on June 19, 2024

@elkhrt I would rather implement relative order (absolute_order=false), but it would change the current state representation (and potentially tests). Is it okay for you?

from open_spiel.

ZiggerZZ avatar ZiggerZZ commented on June 19, 2024

I opened a PR #1118 and updated observation tensors in the tests.

from open_spiel.

lanctot avatar lanctot commented on June 19, 2024

Fixed by #1118 which has now been merged. Closing as resolved, but feel free to re-open if you would like to keep discussing.

from open_spiel.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.