Git Product home page Git Product logo

Comments (10)

dltacube avatar dltacube commented on June 11, 2024

I think mine are being saved but aren't being used. I'm looking into this and will let you know if I find anything but yea, I'm running the same issue.

from alphafold.

dltacube avatar dltacube commented on June 11, 2024

@apelin20 must be something wrong with the cli. If you modify the flag's' default to be True in run_docker.py then it works fyi.

from alphafold.

apelin20 avatar apelin20 commented on June 11, 2024

Hey @dltacube thanks for looking into this. Can you elaborate a little bit, what is cli? and which flag should I change to True in run_docker.py? My singularity container invokes alphafold/run_alphafold.py

Sorry, I am a bit newb at this

from alphafold.

dltacube avatar dltacube commented on June 11, 2024

That's totally fine. If you go to this file here on that line and change False to True I think it might work. modifying the docker_run.py file wouldn't help in your case.

CLI is just command line interface and the part of the code that accepts options like use_precomputed_msas I think might be where the issue lies. Hence why modifying the default value could solve your problem.

from alphafold.

yamule avatar yamule commented on June 11, 2024

hmmsearch and hhsearch are used for template search. Therefore it will run even if --use_precomputed_msas flag is present.
#469 (comment)
The DBs for templates are relatively small so it would not take much time... but it depends on users and their targets.

from alphafold.

apelin20 avatar apelin20 commented on June 11, 2024

from alphafold.

yamule avatar yamule commented on June 11, 2024

I think there is no way to redirect without changing some lines of the python script.
I think the easiest way to speed up is increase the number of cpus to be used.


cmd = [self.binary_path,

(adding '-cpu','number of cpu' around here, i guess)
but the effect will be limited. Possibly no effect when the bottle neck was file IO or your cpu does not have such many cores.

from alphafold.

dltacube avatar dltacube commented on June 11, 2024

There is. I mentioned how in my comment. Just change the default flag to true and it'll do it.

from alphafold.

yamule avatar yamule commented on June 11, 2024

Template search (hmmsearch, hhsearch) is not controlled by --use_precomputed_msas flag, I think.

if self.template_searcher.input_format == 'sto':
pdb_templates_result = self.template_searcher.query(msa_for_templates)
elif self.template_searcher.input_format == 'a3m':
uniref90_msa_as_a3m = parsers.convert_stockholm_to_a3m(msa_for_templates)
pdb_templates_result = self.template_searcher.query(uniref90_msa_as_a3m)
else:
raise ValueError('Unrecognized template input format: '
f'{self.template_searcher.input_format}')

from alphafold.

fredricj avatar fredricj commented on June 11, 2024

The result from the template search is actually saved. The issue is, like @yamule is pointing at, that the code doesn't check whether the output file already exists. In our modifications we have changed this but since the template search is dependent upon the previous parts you would ideally need to compare the timestamps as well before using it. We don't do this, hence why I'm reluctant to share it at this point.

If you want to minimize time spent on redoing work already done on the CPU you would even check if features.pkl already exists and load it into feature_dict .

from alphafold.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.