Comments (5)
Hi @vinkla and thanks for this suggestion, I agree with you the CreateMessageResponse
class should check if $json['response']
is null
.
Perhaps this check is not specific to the CreateMessageResponse
class and should be common to all kind of responses.
Maybe we could implement a way to handle these kinds of status messages? What do you think?
Yes sure, we'll try to do it but it seems to be a very minor issue so we'll certainly do it later (in few weeks or months).
If you want to help you can provide a PR on this by taking into account the fact that the check to implement should be common to all responses if possible.
Thanks.
from php-pushwoosh.
Great! I think a global error handling would be better instead of just updating the CreateMessageResponse
class.
It is a minor issue since this library only works if you've an paid account. In my case, I had just upgraded my the account but the API returned this error anyway. Contacted the support and they said it usually takes up to a half hour before it kicks in.
Thanks for getting back. We're using your library in some of our projects and it works great.
from php-pushwoosh.
Ok, happy to see the library feets your needs, feel free to publish more issues if you think about new features or improvements.
It is a minor issue since this library only works if you've an paid account. In my case, I had just upgraded my the account but the API returned this error anyway. Contacted the support and they said it usually takes up to a half hour before it kicks in.
Ok, perhaps this is an opportunity to augment error messages returned by Pushwoosh by providing additional help with the error (see #14).
from php-pushwoosh.
Fixed with 941161e.
from php-pushwoosh.
👍
from php-pushwoosh.
Related Issues (20)
- PushwooshMock - Abstract method not implemented
- Internal Server Error and vendor folder HOT 7
- Internal Server Error When calling the sample code HOT 6
- Add Algolia doc search HOT 1
- Composer install problems with phpdocumentor HOT 1
- Hey from Pushwoosh! HOT 1
- getMock() undefined in unit tests with HHVM, any idea ? HOT 2
- Run tests with PHP 7.1 HOT 1
- Chrome and Firefox support in RegisterDeviceRequest
- Add a SensioLabs Insight badge
- Be compliant with all PSR naming conventions
- Implement new requests HOT 2
- CreateMessageResponse does not pass along UnknownDevices
- setCURLClient documentation wrong HOT 2
- No DefaultTimeOut HOT 3
- Create a Guzzle HTTP client
- Add `use XXXX` namespaces to examples and readme
- Is this repo still maintained ? HOT 2
- Send push notification only to testDevice
- PHP 8 support?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from php-pushwoosh.