Add Eclipse Collections as a dependency. about reladomo HOT 2 CLOSED

@gs-rezaem

I find Function is passed in a method in NumericAttribute interface. I think there are couple of similar public method that takes GSC Function. How do you want to handle this kind of method that takes GSC Function?

NumericAttribute#getMappedAttributeWithCommonMapper(NumericAttribute calculatedAttribute, Mapper commonMapper, Mapper mapperRemainder, Function parentSelector)

• Option1: Introduce a new Function interface (e.g. ReladomoFunction or any other good name?) that extends both GSC and EC Function, and replace the method signature with the new one
• Option2: Simply deprecate the current method, and add a new method that takes EC Function

How do you think, or any other options you like?

from reladomo.

That method isn't very public (as in, I doubt any app code is calling it directly). That function, however, gets passed around and ends up where other Function objects are, some of which are code generated. So whatever choice we make here, will have a broader effect. I'll go with Option 1 (which will eventually have to implement java.util.Function probably via a default method).
Also, let's keep the discussion in the PR.

from reladomo.