Git Product home page Git Product logo

Comments (3)

hyangah avatar hyangah commented on August 25, 2024

gotelemetry view renders x/telemetry/internal/telemetry.Report data.
According to the definition of x/telemetry/internal/telemetry.Report, the Week is the first day the report covers.

type Report struct {
	Week     string  // first day this report covers (YYYY-MM-DD)
	LastWeek string  // Week field from latest previous report uploaded
	...
}

But, it looks to me that the Uploader sets the TimeEnd (expiryDate) as the Report.Week value. (internal/upload/reports.go)

gotelemetry view's pending telemetry.Report creation also uses TimeEnd to match the uploader's logic.

I am afraid it's too late to fix the Uploader's report generation so it sets Report.Weekwith the first day of the week span.
Can we change the definition of the Report.Week to match the current implementation?

from go.

findleyr avatar findleyr commented on August 25, 2024

Thanks for investigating. Yes, let's update the definition of Week to match the implementation.

from go.

gopherbot avatar gopherbot commented on August 25, 2024

Change https://go.dev/cl/595962 mentions this issue: cmd/gotelemetry: fix chart x-axis time interval display

from go.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.