Comments (3)
gotelemetry view
renders x/telemetry/internal/telemetry.Report
data.
According to the definition of x/telemetry/internal/telemetry.Report, the Week
is the first day the report covers.
type Report struct {
Week string // first day this report covers (YYYY-MM-DD)
LastWeek string // Week field from latest previous report uploaded
...
}
But, it looks to me that the Uploader sets the TimeEnd
(expiryDate
) as the Report.Week
value. (internal/upload/reports.go)
gotelemetry view
's pending telemetry.Report
creation also uses TimeEnd
to match the uploader's logic.
I am afraid it's too late to fix the Uploader's report generation so it sets Report.Week
with the first day of the week span.
Can we change the definition of the Report.Week
to match the current implementation?
from go.
Thanks for investigating. Yes, let's update the definition of Week to match the implementation.
from go.
Change https://go.dev/cl/595962 mentions this issue: cmd/gotelemetry: fix chart x-axis time interval display
from go.
Related Issues (20)
- cmd/compile: panics with generic type alias and based-on constraint [1.23 backport] HOT 2
- net/http: ResponseWriter.ReadFrom writes to HEAD response body HOT 25
- x/perf/cmd/benchstat: ignore lines prefixed with `panic: ` HOT 6
- x/pkgsite: package removal request for https://pkg.go.dev/github.com/amandlaus/gocrypt HOT 6
- x/build/cmd/gomote: add a login command
- proposal: testing: optional prefix for error output HOT 2
- net: UDP sockets on windows error on receive due to ICMP TTL HOT 5
- cmd/compile/internal/importer,go/internal/gcimporter: remove iimport.go export data importers HOT 2
- cmd/compile: allow parameterized type aliases to omit redundant type parameters HOT 3
- io: Unable to write more than 65536 (2^16) bytes HOT 3
- proposal: x/crypto/ssh: allow the client to automatically detect host key algorithms HOT 3
- x/crypto/ssh: calling http.Hijack over forwarded SSH connection blocks forever HOT 2
- hm HOT 1
- x/tools/gopls: Is there any way to filter errors? HOT 3
- proposal: io,net: add WriteMany interface HOT 5
- crypto/x509: func (*Certificate) CheckSignatureFrom HOT 2
- Go package coverage is calculated inconsistently in 1.22.5 HOT 2
- cmd/compile: incorrectly reports `x - minimumValue` overflows for integers HOT 5
- fmt.Printf("%02x", ([]byte)(nil)) outputs "00" HOT 1
- cmd/compile: Inaccurate AuxInt value for newobject call HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from go.