x/tools/go/ssa/builder.go: panic("nil underlyin") while executing *ssa.Program.Build() about go HOT 5 CLOSED

Similar Issues

• x/tools/go/ssa: addNamedLocal panic: runtime error: invalid memory address or nil pointer dereference #58600
• x/tools/go/ssa: panic: cannot convert interface #62085
• x/tools/go/ssa: panic in ssa.(*Program).needMethods with type parameters #50078
• go/ssa: crash during SSA construction #9569
• x/tools/go/ssa: ssautil.Packages panics with the standard library #53604
• x/tools/go/ssa: panic: T #54274
• x/text/cmd/gotext: panic: interface conversion: types.Type is nil, not *types.Signature #51865
• x/tools/go/ssa: emitConv panic on generics #57272
• x/tools/go/ssa/ssautil: clarify that LoadAllSyntax is required, and provide better errors #28106
• x/tools/go/ssa: builder crash in map[*S]bool{{}: true} #13341

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

from go.

the loaded package is "google.golang.org/protobuf/reflect/protoreflect"
it starts with struct EnumValueDescriptor

from go.

The version of x/tools v0.11.0 (from the stack trace) is fairly out of date so you may want to try updating to see if this fixes the issue already.

I am not yet able to reproduce this with go1.20.5 (from the go env) with golang.org/x/tools v0.11.0 and google.golang.org/protobuf v1.34.2. What version of google.golang.org/protobuf/reflect/protoreflect are you analyzing?

Here is what I am doing to try to reproduce this:

# mkdir and cd into it
% cat go.mod 
module example.com/x

go 1.20

require (
        golang.org/x/tools v0.11.0
        google.golang.org/protobuf v1.34.2
)

require (
        golang.org/x/mod v0.12.0 // indirect
        golang.org/x/sys v0.10.0 // indirect
)
% cat m.go
package main

import (
        "log"

        "golang.org/x/tools/go/packages"
        "golang.org/x/tools/go/ssa"
        "golang.org/x/tools/go/ssa/ssautil"

        _ "google.golang.org/protobuf/reflect/protoreflect"
)

func main() {
        fp := "."
        cfg := &packages.Config{
                Mode: packages.NeedSyntax | packages.NeedTypesInfo |
                        packages.NeedTypesSizes | packages.NeedTypes | packages.NeedImports |
                        packages.NeedName | packages.NeedFiles | packages.NeedCompiledGoFiles,
                Dir: fp,
        }
        ps, err := packages.Load(cfg, "google.golang.org/protobuf/reflect/protoreflect")
        if err != nil {
                log.Fatal(err)
                return
        }
        if en := packages.PrintErrors(ps); en > 0 {
                for _, tp := range ps {
                        for _, e := range tp.Errors {
                                err = e
                                break
                        }
                        if err != nil {
                                log.Fatal(err)
                                break
                        }
                }
                return
        }
        prog, sps := ssautil.AllPackages(ps, ssa.InstantiateGenerics)
        // p.ssaFs = prog.Fset
        needAst := true /*conf.needAst*/
        if needAst {
                for _, sp := range sps {
                        sp.SetDebugMode(true)
                }
        }
        prog.Build()

        for _, pkg := range sps {
                for k, m := range pkg.Members {
                        log.Println(pkg.String(), k, ":", m.String())
                }
        }
}
% go1.20.5 build
% ./x # Prints many many members so it is loading and building.

Can you give more details for how to reproduce the crash?

from go.

The version of x/tools v0.11.0 (from the stack trace) is fairly out of date so you may want to try updating to see if this fixes the issue already.

I am not yet able to reproduce this with go1.20.5 (from the go env) with golang.org/x/tools v0.11.0 and google.golang.org/protobuf v1.34.2. What version of google.golang.org/protobuf/reflect/protoreflect are you analyzing?

Here is what I am doing to try to reproduce this:

# mkdir and cd into it
% cat go.mod 
module example.com/x

go 1.20

require (
        golang.org/x/tools v0.11.0
        google.golang.org/protobuf v1.34.2
)

require (
        golang.org/x/mod v0.12.0 // indirect
        golang.org/x/sys v0.10.0 // indirect
)
% cat m.go
package main

import (
        "log"

        "golang.org/x/tools/go/packages"
        "golang.org/x/tools/go/ssa"
        "golang.org/x/tools/go/ssa/ssautil"

        _ "google.golang.org/protobuf/reflect/protoreflect"
)

func main() {
        fp := "."
        cfg := &packages.Config{
                Mode: packages.NeedSyntax | packages.NeedTypesInfo |
                        packages.NeedTypesSizes | packages.NeedTypes | packages.NeedImports |
                        packages.NeedName | packages.NeedFiles | packages.NeedCompiledGoFiles,
                Dir: fp,
        }
        ps, err := packages.Load(cfg, "google.golang.org/protobuf/reflect/protoreflect")
        if err != nil {
                log.Fatal(err)
                return
        }
        if en := packages.PrintErrors(ps); en > 0 {
                for _, tp := range ps {
                        for _, e := range tp.Errors {
                                err = e
                                break
                        }
                        if err != nil {
                                log.Fatal(err)
                                break
                        }
                }
                return
        }
        prog, sps := ssautil.AllPackages(ps, ssa.InstantiateGenerics)
        // p.ssaFs = prog.Fset
        needAst := true /*conf.needAst*/
        if needAst {
                for _, sp := range sps {
                        sp.SetDebugMode(true)
                }
        }
        prog.Build()

        for _, pkg := range sps {
                for k, m := range pkg.Members {
                        log.Println(pkg.String(), k, ":", m.String())
                }
        }
}
% go1.20.5 build
% ./x # Prints many many members so it is loading and building.

Can you give more details for how to reproduce the crash?

thanks for replying. the problem was solved after I updated x/tools to version v0.22.0
I can't neither reproduce this problem with your code, sorry that I can't provide you with the loaded repo, it's a company property.
thanks again.

from go.

solved by updating x/gools to the latest version

from go.