S2: Regioncoverer slightly intersecting another face doesn't cover whole region about geo HOT 7 CLOSED

Yes, looks like we had a couple of typos in the region coverer. I'll try to get a fix out today.

from geo.

Actually the fix might not be so trivial to figure out, but e0bfefd fixes a few little things around it.

from geo.

Hello there , I also made this fix : f509ac2

Intersect returned false if the cell is completely 'inside' the loop.

This fixed this test: 46c3b8b

from geo.

To explain the fix:

Covering returns an empty CellUnion where it should not.

This happens because the generated cell by FastCovering is much bigger than the actual Region ( which is a Loop ) and Cells for which region.IntersectsCell(cell) == false are filtered out inside coverer.newCandidate.

Because the region is fully contained by the cell it does not intersects it.
I thought intersect should return true if the first point of the Loop is inside the cell.

from geo.

Please ignore the two last messages as they just fix a bug from a feature in a commit I tried to merge in from someone else.

Sorry !

from geo.

It's possible that 0c31b84 fixes this bug (by fixing Rect.IntersectsCell). Can you give it a test?

from geo.

I suspect the fix mentioned in my previous comment solves this, but feel free to reply if it doesn't.

from geo.