while creating new client use time.Duration about heimdall HOT 6 CLOSED

Why not default to time.Duration?. Let the client deal with conversion and passing the correct type.

from heimdall.

@kgrz I am not clear on this. What do you have in mind ?

from heimdall.

@rShetty Something like this: master...kgrz:pass-duration-to-client

My main point was to make this the default, instead of switching between int and time.Duration based on the config object. This will avoid the library dictating how the config should look like and keeps it simple.

from heimdall.

👍 Agree

from heimdall.

@kgrz Wanna raise a PR on this ? I think you already did the required change ?

from heimdall.

This is fixed in #13

from heimdall.