Git Product home page Git Product logo

Comments (6)

awalterschulze avatar awalterschulze commented on June 12, 2024

Hmmm good catch.
My opinion is that this was a bug in the original implementation of nullable=false.
I should make a fix that gives all repeated fields and omitempty tag.
What do you think?

from protobuf.

tamird avatar tamird commented on June 12, 2024

I actually would like to not have the omitempty tag, because that means the thing is nullable.

from protobuf.

awalterschulze avatar awalterschulze commented on June 12, 2024

Yes thats true, its only for repeated fields though.
This is how protobuf sends them anyway. It does not send a zero length list.
Are you sure this is what you really want and why?

from protobuf.

tamird avatar tamird commented on June 12, 2024

Actually I don't feel so strongly

from protobuf.

awalterschulze avatar awalterschulze commented on June 12, 2024

Ok great :)
This is then something that should be fixed.

from protobuf.

awalterschulze avatar awalterschulze commented on June 12, 2024

This commit should fix this issue
5ba1012

from protobuf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.